Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ATOM API update, should use distinct class from create for non-writeable fields #12414

Closed
KieranBrantnerMagee opened this issue Jul 7, 2020 · 2 comments · Fixed by #12829
Closed

ATOM API update, should use distinct class from create for non-writeable fields #12414

KieranBrantnerMagee opened this issue Jul 7, 2020 · 2 comments · Fixed by #12829
Assignees
@YijunXieMS
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone
[2020] August

Comments

@KieranBrantnerMagee
Copy link
Member

KieranBrantnerMagee commented Jul 7, 2020 •
edited
Loading

Should we limit the fields that we allow to be updateable when performing an Update operation vs Create?
(to better communicate to a user that certain fields cannot be changed and will error)
@KieranBrantnerMagee KieranBrantnerMagee added Service Bus Client This issue points to a problem in the data-plane of the library. labels Jul 7, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the [2020] August milestone Jul 7, 2020
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Jul 7, 2020
@ramya-rao-a ramya-rao-a added the blocking-release Blocks release label Jul 16, 2020
@KieranBrantnerMagee
Copy link
Member Author

Transferring to Yijun due to accidental duplication of tracking issue; see prototype and arch review q&A here #12741

@YijunXieMS YijunXieMS linked a pull request Aug 3, 2020 that will close this issue
[Service Bus] Normalize management naming with other languages #12829
Merged
@YijunXieMS
Copy link
Contributor

Two changes made in PR #12829 regarding this issue.

  1. Removed updatable properties from **kwargs of update_queue method. Users should update the input queue object. Same applies to Topic, Subscription and Rule
  2. create_queue now uses **kwargs instead of QueueProperties as input. Same for Topic, Subscription and Rule

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@YijunXieMS YijunXieMS

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
[2020] August
Development

Successfully merging a pull request may close this issue.

[Service Bus] Normalize management naming with other languages YijunXieMS/azure-sdk-for-python
3 participants
@ramya-rao-a @KieranBrantnerMagee @YijunXieMS