-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service Bus] Normalize management naming with other languages #12829
Conversation
/azp run python - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
changelog is missing -- and we could carry the changelog for rule support changes into this PR |
sdk/servicebus/azure-servicebus/azure/servicebus/aio/management/_management_client_async.py
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/aio/management/_management_client_async.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/aio/management/_management_client_async.py
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/aio/management/_management_client_async.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/aio/management/_management_client_async.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/aio/management/_management_client_async.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/management/_models.py
Outdated
Show resolved
Hide resolved
:ivar created_at: The exact time the queue was created. | ||
:ivar created_at: The exact time the subscription was created. | ||
:type created_at: ~datetime.datetime | ||
:ivar updated_at: The exact time a message was updated in the queue. | ||
:type updated_at: ~datetime.datetime | ||
:ivar accessed_at: Last time a message was sent, or the last time there was a receive request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have we ever discussed about whether we should "_utc" suffix on the mgmt time related properties?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created issue #12900 to follow up. This needs discussion with other languages and other Python SDKs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! just some comments on trivial stuff, one comment may apply to both sync, async and different entity types.
the properties you want to update. Only a portion of properties can be updated. | ||
Refer to https://docs.microsoft.com/en-us/rest/api/servicebus/update-queue. | ||
|
||
:param queue: The queue that is returned from `get_queue` and has the updated properties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can the "QueueProperties" returned from create_queue/list_queues
be used to update queue? This question may also apply to other entities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would hope/assume the answer is yes across the board? At the end of the day the goal being "only able to update if you have the artifact representing a queue-that-already-exists and is thusly fully populated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the docstring to add create_queue and list_queues. Also added same thing to other entities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, as discussed OOB, I'm good with changelog coming within another PR
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/servicebus/azure-servicebus/azure/servicebus/management/_models.py
Outdated
Show resolved
Hide resolved
Approved assuming we've had a full livetest run :) |
Azure Pipelines successfully started running 1 pipeline(s). |
[Hub Generated] Review request for Microsoft.Cache to add version stable/2021-03-01 (Azure#12829) * Adds base for updating Microsoft.Cache from version preview/2020-10-01-preview to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Add support for persistence and fix other typos * Fix SDK Warning: R2063 OperationIdNounConflictingModelNames * Fix spellcheck error * Fix acronym capitalization in descriptions * Replace local parameters with common-types parameters * Use naming convention consistent with Azure documentation * Update word choice, remove deprecated x-ms-code-generation-setting, and fix operationId * Add x-ms-secret extension and make TLS version a string enum * Suppress errors about secrets being sent in responses
[Hub Generated] Review request for Microsoft.Cache to add version stable/2021-03-01 (Azure#12829) * Adds base for updating Microsoft.Cache from version preview/2020-10-01-preview to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Add support for persistence and fix other typos * Fix SDK Warning: R2063 OperationIdNounConflictingModelNames * Fix spellcheck error * Fix acronym capitalization in descriptions * Replace local parameters with common-types parameters * Use naming convention consistent with Azure documentation * Update word choice, remove deprecated x-ms-code-generation-setting, and fix operationId * Add x-ms-secret extension and make TLS version a string enum * Suppress errors about secrets being sent in responses
* CodeGen from PR 12829 in Azure/azure-rest-api-specs [Hub Generated] Review request for Microsoft.Cache to add version stable/2021-03-01 (#12829) * Adds base for updating Microsoft.Cache from version preview/2020-10-01-preview to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Add support for persistence and fix other typos * Fix SDK Warning: R2063 OperationIdNounConflictingModelNames * Fix spellcheck error * Fix acronym capitalization in descriptions * Replace local parameters with common-types parameters * Use naming convention consistent with Azure documentation * Update word choice, remove deprecated x-ms-code-generation-setting, and fix operationId * Add x-ms-secret extension and make TLS version a string enum * Suppress errors about secrets being sent in responses * test,version,CHANGELOG * remove other usage * fix version Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
ScheduledMessageCount
toTopicRuntimeProperties
#12707 )