Split queue creation and updating to require two separate classes #12741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compensate for lack of granular (patch) update. (to force users to always do a get before an update) Also enables dict-based parameter passing for queue mgmt operations. renames runtime options to runtimeproperties.
KieranBrantnerMagee
added
Service Bus
Client
annatisch
reviewed
Jul 28, 2020
| entry.content.queue_description) | ||
| return runtime_info | ||
|
|
||
| async def create_queue(self, queue: Union[str, QueueDescription], **kwargs) -> QueueDescription: | ||
| async def create_queue(self, queue: Union[str, CreateQueueOptions], **kwargs) -> QueueProperties: |
There was a problem hiding this comment.
We should just get rid of this object and use discrete parameters.
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Feb 1, 2021
Lowered minItems to 0 to match API implementation (Azure#12741)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Feb 1, 2021
Lowered minItems to 0 to match API implementation (Azure#12741)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compensates for lack of granular (patch) update. (to force users to always do a get before an update)
Also enables dict-based parameter passing for queue mgmt operations.
renames runtime options to runtimeproperties.