Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] Update parameters should take keyword name overrides #13043

Closed
KieranBrantnerMagee opened this issue Aug 11, 2020 · 2 comments · Fixed by #18210
Closed

[ServiceBus] Update parameters should take keyword name overrides #13043

KieranBrantnerMagee opened this issue Aug 11, 2020 · 2 comments · Fixed by #18210
Assignees
@yunhaoling
Labels
Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew Service Bus
Milestone
[2021] May

Comments

@KieranBrantnerMagee
Copy link
Member

KieranBrantnerMagee commented Aug 11, 2020 •
edited by yunhaoling
Loading

Per python guidelines:
image
This should apply to the data-plane management update_ calls (and anything else taking the Object parameter).

Note:
There has been discussion about where to allow passing the Object parameter in the consistency review. Unify this discussion with that as well (The desire to not allow the object param as a union type)

https://azure.github.io/azure-sdk/python_design.html#python-client-flatten-args
@KieranBrantnerMagee KieranBrantnerMagee added Service Bus Client This issue points to a problem in the data-plane of the library. labels Aug 11, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the [2020] September milestone Aug 11, 2020
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Aug 11, 2020
@KieranBrantnerMagee
Copy link
Member Author

We were waiting confirmation from the service team in terms of which SHOULD be overrideable, since our expectations were a little bit confused and we should lock on that.

@yunhaoling
Copy link
Contributor

#14807

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Mar 1, 2021
CodeGen from PR 13043 in Azure/azure-rest-api-specs
e105683 
Fix Threat Intelligence Swagger Correctness S360 (Azure#13043)

* Fix Threat Intelligence Swagger Correctness S360

* Add custom word
@yunhaoling yunhaoling modified the milestones: Backlog, [2021] April Mar 11, 2021
@yunhaoling yunhaoling modified the milestones: [2021] April, [2021] May Apr 12, 2021
@lmazuel lmazuel added the Messaging Messaging crew label Apr 12, 2021
@yunhaoling yunhaoling mentioned this issue Apr 21, 2021
Merged
@yunhaoling yunhaoling linked a pull request Apr 21, 2021 that will close this issue
[ServiceBus] add keyword override support to update_ methods in mgmt module #18210
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yunhaoling yunhaoling

Labels
Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew Service Bus
Projects
None yet
Milestone
[2021] May
3 participants
@lmazuel @KieranBrantnerMagee @yunhaoling