Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceBus dict-representation acceptance and kwarg-update functionality #14807

Merged
merged 38 commits into from
Mar 3, 2021
Merged

ServiceBus dict-representation acceptance and kwarg-update functionality #14807

merged 38 commits into from
Mar 3, 2021

Conversation

bradleydamato
Copy link
Contributor

@bradleydamato bradleydamato commented Oct 27, 2020 •
edited by yunhaoling
Loading

addressing issue: #14335

bradleydamato and others added 10 commits October 12, 2020 09:42
@ghost ghost added Service Bus customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Oct 27, 2020
@ghost
Copy link

ghost commented Oct 27, 2020

Thank you for your contribution bradleydamato! We will review the pull request and get back to you soon.

@bradleydamato bradleydamato mentioned this pull request Oct 27, 2020
Closed
@bradleydamato
Copy link
Contributor Author

image
Tests as-currently-written are passing. I will add new tests tonight and run again.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@KieranBrantnerMagee
Copy link
Member

Hey @bradleydamato , thanks again for all your work on this, very appreciated to save us the effort! Left some comments, don't hesitate to ping back if any questions on them or broader clarity needed.

As an FYI, the conflicts that popped up are hopefully minimal (due to an refactor on the core surface area motivated by architect asks, and likely only intersects very tangentially with what you're doing) but as above shout if I can lend hands with anything, since that's "on us" for pushing in the broad changes before getting to these smaller PRs, and I'd like to not make life TOO much harder on you as a result of that choice :)

@KieranBrantnerMagee KieranBrantnerMagee mentioned this pull request Dec 1, 2020
Closed
@yunhaoling yunhaoling mentioned this pull request Dec 8, 2020
Closed
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Member

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yunhaoling
yunhaoling approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@yunhaoling yunhaoling left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annatisch
do you think this feature would be worth a minor version bump to 7.1.0?
I know Swathi had a discussion with you that we don't want to encourage people to use dict and we're not gonna explicitly mention it so I'm thinking of just do a 7.0.2 release as there're no explicit API changes we want to mention.

annatisch
annatisch reviewed Mar 1, 2021
View reviewed changes
sdk/servicebus/azure-servicebus/azure/servicebus/_common/message.py Show resolved Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/_common/utils.py Outdated Show resolved Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/aio/_servicebus_sender_async.py
self._check_live()
messages = create_messages_from_dicts_if_needed(messages, ServiceBusMessage) # type: ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did typing need to be ignored here, but not line 315?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It results in the following mypy error:
Incompatible types in assignment (expression has type "Union[ServiceBusMessage, List[ServiceBusMessage], ServiceBusMessageBatch]", variable has type "Union[ServiceBusMessage, List[ServiceBusMessage]]").

Since schedule_messages doesn't accept SBMessageBatch, reassigning messages to the result of create_messages_from_dicts_if_needed (which accepts all 3) leads to this error. send_messages doesn't do this because it accepts all 3, so reassigning message doesn't lead to incompatible types.

sdk/servicebus/azure-servicebus/azure/servicebus/_common/message.py Show resolved Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/management/_utils.py Outdated Show resolved Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/management/_utils.py Outdated Show resolved Hide resolved
@swathipil swathipil mentioned this pull request Mar 2, 2021
Closed
@swathipil
Copy link
Member

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling
Copy link
Contributor

hey @swathipil , we also need to update version number in the _version.py to 7.1.0, otherwise the CI would report error.

@swathipil
Copy link
Member

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil swathipil merged commit 3c48ef0 into Azure:master Mar 3, 2021
iscai-msft added a commit that referenced this pull request Mar 3, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
c31c0f9 
…into add_sample_check

* 'master' of https://github.com/Azure/azure-sdk-for-python: (388 commits)
  [text analytics] add normalized_text (#17074)
  Renaming with_token identity function (#17066)
  Adapt to azure core's cloud event (#17063)
  align perf tests with js (#17069)
  [Perfstress][Storage] Added FileShare perf tests (#15834)
  [formrecognizer] Adding custom forms perf test (#16969)
  Fix LanguageShort typo (#17068)
  sas creds updates (#17065)
  [eventgrid] Fix Sample eh (#17064)
  [Perfstress][Storage] Added Datalake perf tests (#15861)
  [text analytics] Healthcare n-ary relations (#16997)
  ServiceBus dict-representation acceptance and kwarg-update functionality  (#14807)
  [text analytics] add perf tests (#17060)
  Add cloud event to core (#16800)
  [Perf] Small fixes to storage-blob (#17055)
  [EG] Regenerate Code (#17053)
  Scrub batch shared keys (#17030)
  [Tables] Add SAS to tables (#16717)
  T2 containerservice 2021 03 03 (#17050)
  Addressing issues with CredScan (#16944)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 4, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
2bb425f 
…into add_query_kwarg

* 'master' of https://github.com/Azure/azure-sdk-for-python: (69 commits)
  march release (Azure#16966)
  Release of Device Update for IoT Hub SDK for Python. (Azure#17005)
  Add Get-AllPackageInfoFromRepo (Azure#16947)
  Track1 package is incorrectly set as track2 (Azure#17075)
  [text analytics] add normalized_text (Azure#17074)
  Renaming with_token identity function (Azure#17066)
  Adapt to azure core's cloud event (Azure#17063)
  align perf tests with js (Azure#17069)
  [Perfstress][Storage] Added FileShare perf tests (Azure#15834)
  [formrecognizer] Adding custom forms perf test (Azure#16969)
  Fix LanguageShort typo (Azure#17068)
  sas creds updates (Azure#17065)
  [eventgrid] Fix Sample eh (Azure#17064)
  [Perfstress][Storage] Added Datalake perf tests (Azure#15861)
  [text analytics] Healthcare n-ary relations (Azure#16997)
  ServiceBus dict-representation acceptance and kwarg-update functionality  (Azure#14807)
  [text analytics] add perf tests (Azure#17060)
  Add cloud event to core (Azure#16800)
  [Perf] Small fixes to storage-blob (Azure#17055)
  [EG] Regenerate Code (Azure#17053)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 4, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
f66bdb4 
…into add_reprs

* 'master' of https://github.com/Azure/azure-sdk-for-python: (71 commits)
  EG - more docs imrpovement (Azure#17079)
  [EventHubs] add logging.info to warn the usage of partition key of non-string type (Azure#17057)
  march release (Azure#16966)
  Release of Device Update for IoT Hub SDK for Python. (Azure#17005)
  Add Get-AllPackageInfoFromRepo (Azure#16947)
  Track1 package is incorrectly set as track2 (Azure#17075)
  [text analytics] add normalized_text (Azure#17074)
  Renaming with_token identity function (Azure#17066)
  Adapt to azure core's cloud event (Azure#17063)
  align perf tests with js (Azure#17069)
  [Perfstress][Storage] Added FileShare perf tests (Azure#15834)
  [formrecognizer] Adding custom forms perf test (Azure#16969)
  Fix LanguageShort typo (Azure#17068)
  sas creds updates (Azure#17065)
  [eventgrid] Fix Sample eh (Azure#17064)
  [Perfstress][Storage] Added Datalake perf tests (Azure#15861)
  [text analytics] Healthcare n-ary relations (Azure#16997)
  ServiceBus dict-representation acceptance and kwarg-update functionality  (Azure#14807)
  [text analytics] add perf tests (Azure#17060)
  Add cloud event to core (Azure#16800)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 4, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
bf5990f 
…into http_response_json

* 'master' of https://github.com/Azure/azure-sdk-for-python: (165 commits)
  EG - more docs imrpovement (Azure#17079)
  [EventHubs] add logging.info to warn the usage of partition key of non-string type (Azure#17057)
  march release (Azure#16966)
  Release of Device Update for IoT Hub SDK for Python. (Azure#17005)
  Add Get-AllPackageInfoFromRepo (Azure#16947)
  Track1 package is incorrectly set as track2 (Azure#17075)
  [text analytics] add normalized_text (Azure#17074)
  Renaming with_token identity function (Azure#17066)
  Adapt to azure core's cloud event (Azure#17063)
  align perf tests with js (Azure#17069)
  [Perfstress][Storage] Added FileShare perf tests (Azure#15834)
  [formrecognizer] Adding custom forms perf test (Azure#16969)
  Fix LanguageShort typo (Azure#17068)
  sas creds updates (Azure#17065)
  [eventgrid] Fix Sample eh (Azure#17064)
  [Perfstress][Storage] Added Datalake perf tests (Azure#15861)
  [text analytics] Healthcare n-ary relations (Azure#16997)
  ServiceBus dict-representation acceptance and kwarg-update functionality  (Azure#14807)
  [text analytics] add perf tests (Azure#17060)
  Add cloud event to core (Azure#16800)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swathipil swathipil swathipil left review comments

@yunhaoling yunhaoling yunhaoling approved these changes

@KieranBrantnerMagee KieranBrantnerMagee KieranBrantnerMagee left review comments

@annatisch annatisch annatisch approved these changes

@00Kai0 00Kai0 Awaiting requested review from 00Kai0

@changlong-liu changlong-liu Awaiting requested review from changlong-liu

@jsntcy jsntcy Awaiting requested review from jsntcy

@msyyc msyyc Awaiting requested review from msyyc

@rakshith91 rakshith91 Awaiting requested review from rakshith91

Assignees
No one assigned
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ServiceBus] Functions should take dict-representations of objects, and optional kwarg-parameters for updates
5 participants
@bradleydamato @KieranBrantnerMagee @swathipil @yunhaoling @annatisch