Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACR] [Before GA] Update cloud configuration API #19610

Closed
7 tasks done
annelo-msft opened this issue Jun 30, 2021 · 2 comments
Closed
7 tasks done

[ACR] [Before GA] Update cloud configuration API #19610

annelo-msft opened this issue Jun 30, 2021 · 2 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry

Comments

@annelo-msft
Copy link
Member

annelo-msft commented Jun 30, 2021

Once the service team has added data plane scopes, we will update our authentication_scope kwarg as follows:

  • Remove authentication_scope kwarg
  • Add audience (or similarly named) kwarg
  • audience is an extensible enum, containing the audience strings for known clouds; the user can override with a string if needed
  • If audience is set, client library will append /.default to audience value to specify the default scope
  • audience will default to data-plane scope root, which should be common across clouds [Note: this is not yet available from the service]
  • Throw an exception is audience is not set and update samples to reflect this

In Python, we will also

  • Initially not support credential_scopes kwarg
  • If we do evenually support the credential_scopes kwarg, raise an error if this is different from the scope determined from audience

Please see Azure/azure-sdk-for-net#21603 for further details.

@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Container Registry labels Jun 30, 2021
@annelo-msft annelo-msft added this to the [2021] August milestone Jun 30, 2021
@annelo-msft
Copy link
Member Author

@johanste @lmazuel @schaabs FYI

@YalinLi0312
Copy link
Member

Fixed.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Jul 5, 2022
update swagger and generate examples (Azure#19610)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Projects
None yet
Development

No branches or pull requests

3 participants