Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACR] Update cloud configuration API #20464

Merged
merged 12 commits into from
Sep 3, 2021
Merged

Conversation

YalinLi0312
Copy link

For issue: #19610

@ghost ghost added the Container Registry label Aug 30, 2021
@YalinLi0312 YalinLi0312 changed the title Add audience kwarg [ACR] Update cloud configuration API Aug 30, 2021
@YalinLi0312
Copy link
Author

@annelo-msft Thanks for your review!

I updated the name to be without the _VALUE suffix, and the credential_scopes kwarg is waiting Anna's confirmation.

Thanks

@YalinLi0312
Copy link
Author

/check-enforcer reset

@YalinLi0312
Copy link
Author

/check-enforcer override

@YalinLi0312
Copy link
Author

/check-enforcer reset

Copy link
Member

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please make sure someone from the Python teams signs off on this as well.

@YalinLi0312 YalinLi0312 merged commit 1bb8e93 into Azure:main Sep 3, 2021
@YalinLi0312 YalinLi0312 deleted the yall-acr19610 branch September 3, 2021 21:35
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Sep 7, 2021
…into switch_to_protocol

* 'main' of https://github.com/Azure/azure-sdk-for-python: (53 commits)
  Smoke test package verification (Azure#20547)
  Update CHANGELOG.md (Azure#20569)
  updating codeowners (Azure#20570)
  Simplify recorded OnBehalfOfCredential tests (Azure#20568)
  Search: update release date (Azure#20564)
  [Exporter] Support redirect response in exporter (Azure#20489)
  [AutoRelease] t2-synapse-2021-09-06-18774 (Azure#20552)
  [AutoRelease] t2-logz-2021-08-26-01773 (Azure#20426)
  [AutoRelease] t2-relay-2021-09-03-32777 (Azure#20530)
  [AutoRelease] t2-resource-2021-09-03-61345 (Azure#20527)
  [AutoRelease] t2-servicefabric-2021-09-02-41879 (Azure#20512)
  [Keyvault] Remove exception message parsing from samples in keys, certificates and secrets (Azure#20540)
  [ACR] Update cloud configuration API (Azure#20464)
  Get rid of generated code (Azure#20536)
  Search: Skill Versions (Azure#20431)
  Check fd is reg file or symlink in get_length before using st_size. (Azure#19725)
  Add OnBehalfOfCredential (Azure#20451)
  Fix incorrect parsing of message from Exception (Azure#20534)
  [Release sdk status] swagger repo default branch changes to `main` (Azure#20529)
  [AutoRelease] t2-rdbms-2021-09-02-91864 (Azure#20513)
  ...
iscai-msft pushed a commit that referenced this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants