Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventHub] check for correct send tracing behavior #28141

Closed
swathipil opened this issue Jan 3, 2023 · 0 comments
Closed

[EventHub] check for correct send tracing behavior #28141

swathipil opened this issue Jan 3, 2023 · 0 comments
Assignees
@kashifkhan @swathipil @l0lawrence
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Messaging Messaging crew
Milestone
Backlog

Comments

@swathipil
Copy link
Member

swathipil commented Jan 3, 2023 •
edited
Loading

  • Confirm that "send span" links should include contexts for all messages being sent.
    • ([Original issue] indicates that this should be true, but implementation does not follow. [PR] that changed behavior.)
    • As per Liudmila: " send span should have link to all messages being sent. It may be skipped if a single message is being sent. Nothing has changed since I created the issue."
  • Test links/children/etc. for sync and async send.
@swathipil swathipil added Event Hubs Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew labels Jan 3, 2023
@swathipil swathipil added this to the Backlog milestone Jan 3, 2023
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 3, 2023
@swathipil swathipil removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 3, 2023
@swathipil swathipil mentioned this issue Jan 3, 2023
Merged
ghost pushed a commit that referenced this issue Jan 6, 2023
@swathipil
[EventHubs] fix tracing bug (#28149)
c2e787f 
fixes bug in: #27986

changes:
- removed duplicate tracing which was adding the `Azure.EventHubs.Message` span twice when sending a batch message/list of messages.
- adding the tracing info the uamqp/pyamqp.Message application_properties rather than event_data. Ensures that the diagnostic ID is actually being added on the outgoing Message, rather than the EventData after outgoing Message has already been created.
- Adding the FakeSpan class to `tests` folder to test telemetry.

TODO:
- follow-up issue created to address implementation so it behaves correctly in a separate PR: #28141
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kashifkhan kashifkhan

@swathipil swathipil

@l0lawrence l0lawrence

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Messaging Messaging crew
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@kashifkhan @swathipil @l0lawrence