Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventHubs] fix tracing bug #28149

Merged
7 commits merged into from
Jan 6, 2023
Merged

Conversation

swathipil
Copy link
Member

@swathipil swathipil commented Jan 3, 2023

fixes bug in: #27986

changes:

  • removed duplicate tracing which was adding the Azure.EventHubs.Message span twice when sending a batch message/list of messages.
  • adding the tracing info the uamqp/pyamqp.Message application_properties rather than event_data. Ensures that the diagnostic ID is actually being added on the outgoing Message, rather than the EventData after outgoing Message has already been created.
  • Adding the FakeSpan class to tests folder to test telemetry.

TODO:

@ghost ghost added the Event Hubs label Jan 3, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@swathipil
Copy link
Member Author

swathipil commented Jan 4, 2023

@swathipil swathipil marked this pull request as ready for review January 4, 2023 22:44
@swathipil swathipil requested a review from annatisch as a code owner January 4, 2023 22:44
@swathipil swathipil requested a review from kashifkhan January 5, 2023 01:00
Copy link
Member

@kashifkhan kashifkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@swathipil
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Jan 6, 2023

Hello @swathipil!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit c2e787f into Azure:main Jan 6, 2023
iscai-msft added a commit that referenced this pull request Apr 26, 2023
…into version_tolerant_models

* 'main' of https://github.com/Azure/azure-sdk-for-python: (1604 commits)
  [Storage] Matching `_shared` folder contents across all packages (#28031)
  [ml] Rename MLException back to MlException (#28210)
  [EventHubs] update readme to include uamqp backcompat section (#28198)
  [Monitor][Ingestion] Adjust upload error handling (#27556)
  Add 3.11 to QA (#28169)
  p1 component deployment exisitng job definition (#28194)
  Typing for identity (#28159)
  [ServiceBus] Allow clearing of session state (#27726)
  [ML][Pipelines] Fix parallel-for validation rule: allow empty dict as loop config item (#28178)
  [ML][Pipelines] feat: enable concurrent component registration (#28118)
  [ML][Pipelines] Test: update invalid reuse test (#28180)
  [AutoRelease] t2-loadtesting-2022-12-23-48532(can only be merged by SDK owner) (#28042)
  [ML][Pipelines] Test: update unstable tests in ci (#28157)
  [ML]: Adding experimental decorator to JobDefinition (#28200)
  [Identity] Fix 'az' existence check in CliCred (#27991)
  [EventHubs] fix tracing bug (#28149)
  ShortForMigrateFrom (#28192)
  Address the API review comments (#28188)
  [SchemaRegistryAvro] update recordings (#28158)
  [EventHub] update uamqp_transport docstring (#28186)
  ...
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants