-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Matching _shared
folder contents across all packages
#28031
Merged
vincenttran-msft
merged 10 commits into
Azure:main
from
vincenttran-msft:vincenttran/matching_shared
Jan 6, 2023
Merged
[Storage] Matching _shared
folder contents across all packages
#28031
vincenttran-msft
merged 10 commits into
Azure:main
from
vincenttran-msft:vincenttran/matching_shared
Jan 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/response_handlers.py
Show resolved
Hide resolved
...ge/azure-storage-file-datalake/azure/storage/filedatalake/_shared/shared_access_signature.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/uploads.py
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_shared/authentication.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_shared/base_client.py
Outdated
Show resolved
Hide resolved
vincenttran-msft
commented
Jan 4, 2023
sdk/storage/azure-storage-queue/azure/storage/queue/_shared/response_handlers.py
Show resolved
Hide resolved
vincenttran-msft
commented
Jan 4, 2023
sdk/storage/azure-storage-queue/azure/storage/queue/_shared/request_handlers.py
Show resolved
Hide resolved
API change check API changes are not detected in this pull request. |
vincenttran-msft
commented
Jan 5, 2023
sdk/storage/azure-storage-queue/azure/storage/queue/_shared/uploads_async.py
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/base_client_async.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/uploads.py
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_shared/request_handlers.py
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_shared/uploads_async.py
Show resolved
Hide resolved
jalauzon-msft
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for working through this!
iscai-msft
added a commit
that referenced
this pull request
Apr 26, 2023
…into version_tolerant_models * 'main' of https://github.com/Azure/azure-sdk-for-python: (1604 commits) [Storage] Matching `_shared` folder contents across all packages (#28031) [ml] Rename MLException back to MlException (#28210) [EventHubs] update readme to include uamqp backcompat section (#28198) [Monitor][Ingestion] Adjust upload error handling (#27556) Add 3.11 to QA (#28169) p1 component deployment exisitng job definition (#28194) Typing for identity (#28159) [ServiceBus] Allow clearing of session state (#27726) [ML][Pipelines] Fix parallel-for validation rule: allow empty dict as loop config item (#28178) [ML][Pipelines] feat: enable concurrent component registration (#28118) [ML][Pipelines] Test: update invalid reuse test (#28180) [AutoRelease] t2-loadtesting-2022-12-23-48532(can only be merged by SDK owner) (#28042) [ML][Pipelines] Test: update unstable tests in ci (#28157) [ML]: Adding experimental decorator to JobDefinition (#28200) [Identity] Fix 'az' existence check in CliCred (#27991) [EventHubs] fix tracing bug (#28149) ShortForMigrateFrom (#28192) Address the API review comments (#28188) [SchemaRegistryAvro] update recordings (#28158) [EventHub] update uamqp_transport docstring (#28186) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to unify all the contents of the
_shared
folders for the blob, datalake, queue, and file-share packages.In general, my process was to use blob's
_shared
folder as the "source of truth" for most things as it is where most new changes will be added (and then not uniformly added to the other_shared
folders)Things to callout when unifying:
shared_access_signature.py
will be different for file-share and queue since they do not support encryption scopeparser.py
is mostly barren except for in blob -- I opted to copy blob'sparser.py
to every other file (which is likely overkill) just because I anticipate most new features in blob that require these parser changes will eventually trickle down to other packagesresponse_handlers.py
metadata parsing went fromresponse.headers.items
toresponse.http_reponse.headers.items
. Not sure how this will play out because I'm assuming if it works in its current state, will the same information be contained inresponse.http_response
vsresponse.headers
? Pending pipeline run for the answer 😄policies.py
specifically theon_request
method, thequeue
package is the only file with this workaround (and thus will differ from other files):Therefore, the only differences in the
_shared
folders now is:shared_access_signature.py
differences for packages that don't support encryption scope (file-share & queue)