-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing for identity #28159
Typing for identity #28159
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you remove azure-identity from being blocked from any of the CI checks here? https://github.com/Azure/azure-sdk-for-python/blob/main/tools/azure-sdk-tools/ci_tools/environment_exclusions.py
sdk/identity/azure-identity/azure/identity/_credentials/authorization_code.py
Show resolved
Hide resolved
sdk/identity/azure-identity/azure/identity/_credentials/azure_powershell.py
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/azure/identity/_credentials/environment.py
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/azure/identity/_credentials/imds.py
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/azure/identity/_internal/managed_identity_client.py
Show resolved
Hide resolved
sdk/identity/azure-identity/azure/identity/aio/_credentials/azure_cli.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah, we will definitely need a while before we can enable the pyright CI check. Verifytypes showing an improvement in type completeness score from 8.6% -> 11.4%. But we can slowly chip away at these over time in order to push this score higher.
…into version_tolerant_models * 'main' of https://github.com/Azure/azure-sdk-for-python: (1604 commits) [Storage] Matching `_shared` folder contents across all packages (#28031) [ml] Rename MLException back to MlException (#28210) [EventHubs] update readme to include uamqp backcompat section (#28198) [Monitor][Ingestion] Adjust upload error handling (#27556) Add 3.11 to QA (#28169) p1 component deployment exisitng job definition (#28194) Typing for identity (#28159) [ServiceBus] Allow clearing of session state (#27726) [ML][Pipelines] Fix parallel-for validation rule: allow empty dict as loop config item (#28178) [ML][Pipelines] feat: enable concurrent component registration (#28118) [ML][Pipelines] Test: update invalid reuse test (#28180) [AutoRelease] t2-loadtesting-2022-12-23-48532(can only be merged by SDK owner) (#28042) [ML][Pipelines] Test: update unstable tests in ci (#28157) [ML]: Adding experimental decorator to JobDefinition (#28200) [Identity] Fix 'az' existence check in CliCred (#27991) [EventHubs] fix tracing bug (#28149) ShortForMigrateFrom (#28192) Address the API review comments (#28188) [SchemaRegistryAvro] update recordings (#28158) [EventHub] update uamqp_transport docstring (#28186) ...
No description provided.