Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML][Pipelines] Test: update invalid reuse test #28180

Merged
merged 3 commits into from
Jan 6, 2023
Merged

[ML][Pipelines] Test: update invalid reuse test #28180

merged 3 commits into from
Jan 6, 2023

Conversation

zhengfeiwang
Copy link
Member

@zhengfeiwang zhengfeiwang commented Jan 5, 2023

Description

According to recent client & service changes, anonymous component with different name will be created as different component instance, which also leads to reuse in such scenario not work any more. This PR updates test_anonymous_component_reuse to cover this change.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@zhengfeiwang zhengfeiwang changed the title [ML][Pipelines] Test: remove invalid reuse test [ML][Pipelines] Test: update invalid reuse test Jan 5, 2023
@wangchao1230 wangchao1230 merged commit b928be3 into Azure:main Jan 6, 2023
@zhengfeiwang zhengfeiwang deleted the test/remove-useless-test-0105 branch January 6, 2023 08:41
iscai-msft added a commit that referenced this pull request Apr 26, 2023
…into version_tolerant_models

* 'main' of https://github.com/Azure/azure-sdk-for-python: (1604 commits)
  [Storage] Matching `_shared` folder contents across all packages (#28031)
  [ml] Rename MLException back to MlException (#28210)
  [EventHubs] update readme to include uamqp backcompat section (#28198)
  [Monitor][Ingestion] Adjust upload error handling (#27556)
  Add 3.11 to QA (#28169)
  p1 component deployment exisitng job definition (#28194)
  Typing for identity (#28159)
  [ServiceBus] Allow clearing of session state (#27726)
  [ML][Pipelines] Fix parallel-for validation rule: allow empty dict as loop config item (#28178)
  [ML][Pipelines] feat: enable concurrent component registration (#28118)
  [ML][Pipelines] Test: update invalid reuse test (#28180)
  [AutoRelease] t2-loadtesting-2022-12-23-48532(can only be merged by SDK owner) (#28042)
  [ML][Pipelines] Test: update unstable tests in ci (#28157)
  [ML]: Adding experimental decorator to JobDefinition (#28200)
  [Identity] Fix 'az' existence check in CliCred (#27991)
  [EventHubs] fix tracing bug (#28149)
  ShortForMigrateFrom (#28192)
  Address the API review comments (#28188)
  [SchemaRegistryAvro] update recordings (#28158)
  [EventHub] update uamqp_transport docstring (#28186)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants