Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event Hubs] Use EventHubManagementClient to create test resources #12501

Merged
merged 11 commits into from
Jul 22, 2020
Merged

[Event Hubs] Use EventHubManagementClient to create test resources #12501

merged 11 commits into from
Jul 22, 2020

Conversation

YijunXieMS
Copy link
Contributor

@YijunXieMS YijunXieMS commented Jul 11, 2020 •
edited
Loading

  1. To remove dependency on azure-servicebus control client to create eventhub resources for testing. To use azure-mgmt-eventhub. azure-servicebus is going to remove the control client.
  2. To create a resource group and an eventhub namespace with random names for each test run (pytest fixture scope "session") and delete them after test finishes. The test currently uses a pre-created eventhub namespace, in which at most 10 eventhubs can be created. With this change

@YijunXieMS YijunXieMS added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Jul 11, 2020
@YijunXieMS
Copy link
Contributor Author

YijunXieMS commented Jul 11, 2020 •
edited
Loading

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Command 'python' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@YijunXieMS YijunXieMS marked this pull request as ready for review July 13, 2020 21:20
@YijunXieMS YijunXieMS requested review from KieranBrantnerMagee and removed request for danieljurek July 13, 2020 21:21
@KieranBrantnerMagee
Copy link
Member

If I can ask a favor; if we don't already have an issue to convert EH tests to use preparer, could we create one on the backlog, tag it as Up for Grabs, and note the interaction with the parameterize fixture that makes it difficult for now? Just want to persist both our desire to do this and the reason we paused for now.

@yunhaoling
Copy link
Contributor

Nice work, in general this looks good to me (and we would move to preparer if possible in the future as Kieran mentioned).

BTW, live tests are all good with the updates?

@YijunXieMS @yunhaoling
Update skip reason
4ef90b8 
Co-authored-by: Adam Ling (MSFT) <47871814+yunhaoling@users.noreply.github.com>
@YijunXieMS
Copy link
Contributor Author

If I can ask a favor; if we don't already have an issue to convert EH tests to use preparer, could we create one on the backlog, tag it as Up for Grabs, and note the interaction with the parameterize fixture that makes it difficult for now? Just want to persist both our desire to do this and the reason we paused for now.

Added issue #12616 in backlog

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yunhaoling
yunhaoling previously approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YijunXieMS
Copy link
Contributor Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@YijunXieMS YijunXieMS merged commit b23ccbd into Azure:master Jul 22, 2020
@YijunXieMS YijunXieMS mentioned this pull request Jul 23, 2020
Closed
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jul 29, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
e1f08b2 
…into regenerate_keys

* 'master' of https://github.com/Azure/azure-sdk-for-python: (24 commits)
  rename FormField.type -> FormField.value_type (Azure#12708)
  20200703 codereport (Azure#12361)
  Use the common Cosmos emulator template. (Azure#12678)
  Add azurestackhci ci.yml for pipeline generation. (Azure#12701)
  [ServiceBus] Resend received message (Azure#12457)
  AZURE_CLIENT_ID sets user-assigned managed identity for DefaultAzureCredential (Azure#12689)
  Add better autolockrenew on-failure handling capabilities. (Azure#12307)
  Update CODEOWNERS (Azure#12418)
  close client session in async tests (Azure#12656)
  Sync eng/common directory with azure-sdk-tools repository (Azure#12502)
  [Event Hubs] Use EventHubManagementClient to create test resources (Azure#12501)
  Increment package version after release of azure_identity (Azure#12675)
  [formrecognizer] include error code for errors that occur during polling (Azure#12621)
  Cross-language consistency changes (Azure#12669)
  Enable APIStubGen step (Azure#12615)
  Adding the ability to create a container with analytical storage turned on. (Azure#12408)
  [ServiceBus] Adjust user-agent following the guideline (Azure#12596)
  Release for Cognitive Services - Anomaly Detector (Azure#12582)
  [formrecognizer] Add type to FormField (Azure#12561)
  Add example summary for azure-identity readme.md (Azure#12509)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KieranBrantnerMagee KieranBrantnerMagee KieranBrantnerMagee approved these changes

@yunhaoling yunhaoling yunhaoling left review comments

@annatisch annatisch Awaiting requested review from annatisch

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YijunXieMS @KieranBrantnerMagee @yunhaoling