[formrecognizer] include error code for errors that occur during polling #12621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristapratico
added
Client
kristapratico
commented
Jul 21, 2020
| for err in errors: | ||
| message += "({}) {}\n".format(err["code"], err["message"]) | ||
| raise HttpResponseError(message=message, response=response) | ||
| error_message = "({}) {}{}".format(errors[0]["code"], errors[0]["message"], message) |
There was a problem hiding this comment.
aligning with other languages to raise the first error in the list
iscai-msft
reviewed
Jul 21, 2020
| poller = client.begin_copy_model(model.model_id, target=target) | ||
| copy = poller.result() | ||
| except HttpResponseError as e: |
There was a problem hiding this comment.
I had a test similar to this and I thought it was passing, but it turns out it wasn't actually raising an HttpResponseError, so none of my asserts were actually being checked. Definitely recommend using with pytest.raises. Example here
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jul 29, 2020
…into regenerate_keys * 'master' of https://github.com/Azure/azure-sdk-for-python: (24 commits) rename FormField.type -> FormField.value_type (Azure#12708) 20200703 codereport (Azure#12361) Use the common Cosmos emulator template. (Azure#12678) Add azurestackhci ci.yml for pipeline generation. (Azure#12701) [ServiceBus] Resend received message (Azure#12457) AZURE_CLIENT_ID sets user-assigned managed identity for DefaultAzureCredential (Azure#12689) Add better autolockrenew on-failure handling capabilities. (Azure#12307) Update CODEOWNERS (Azure#12418) close client session in async tests (Azure#12656) Sync eng/common directory with azure-sdk-tools repository (Azure#12502) [Event Hubs] Use EventHubManagementClient to create test resources (Azure#12501) Increment package version after release of azure_identity (Azure#12675) [formrecognizer] include error code for errors that occur during polling (Azure#12621) Cross-language consistency changes (Azure#12669) Enable APIStubGen step (Azure#12615) Adding the ability to create a container with analytical storage turned on. (Azure#12408) [ServiceBus] Adjust user-agent following the guideline (Azure#12596) Release for Cognitive Services - Anomaly Detector (Azure#12582) [formrecognizer] Add type to FormField (Azure#12561) Add example summary for azure-identity readme.md (Azure#12509) ...
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Feb 3, 2021
APIM Missing Operations reported in S360 (Azure#12621) * missing operations * swagger linter issues * suppression * add count property * fix swagger model issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.