Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing version issue by not overwriting the version with the semantic… #13411

Merged
merged 3 commits into from
Aug 31, 2020

Conversation

seankane-msft
Copy link
Member

TableClient and TableServiceClient overwrite the api_version in the constructor which causes issues with the HTTP headers.

kristapratico
kristapratico previously approved these changes Aug 29, 2020
@iscai-msft
Copy link
Contributor

@seankane-msft going to wait for pylint to approve so my stale review is not dismissed

@seankane-msft seankane-msft merged commit 4f859ec into Azure:master Aug 31, 2020
@seankane-msft seankane-msft deleted the version-isse branch August 31, 2020 17:03
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Sep 1, 2020
…into add_redacted_text

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [text analytics] add bing_id property to LinkedEntity class (Azure#13446)
  fix typing for paging methods (Azure#13410)
  [text analytics] add domain_filter param (Azure#13451)
  fix issue Azure#11658 for is_valid_resource_id (Azure#11709)
  added create_table_if_not_exists method to table service client (Azure#13385)
  [ServiceBus] Test and failure improvements (Azure#13345)
  Proper encoding and decoding of source URLs - Fixes special characters in source URL issue (Azure#13275)
  Switch retry (Azure#13264)
  [ServiceBus] ServiceBusClient close spawned children (Azure#13077)
  fixing version issue by not overwriting the version with the semantic… (Azure#13411)
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Sep 1, 2020
…into expose_parse_vault_id

* 'master' of https://github.com/Azure/azure-sdk-for-python: (37 commits)
  [text analytics] add versionadded sphinx documentation (Azure#13450)
  [text analytics] add bing_id property to LinkedEntity class (Azure#13446)
  fix typing for paging methods (Azure#13410)
  [text analytics] add domain_filter param (Azure#13451)
  fix issue Azure#11658 for is_valid_resource_id (Azure#11709)
  added create_table_if_not_exists method to table service client (Azure#13385)
  [ServiceBus] Test and failure improvements (Azure#13345)
  Proper encoding and decoding of source URLs - Fixes special characters in source URL issue (Azure#13275)
  Switch retry (Azure#13264)
  [ServiceBus] ServiceBusClient close spawned children (Azure#13077)
  fixing version issue by not overwriting the version with the semantic… (Azure#13411)
  clean up reference and tests (Azure#13412)
  Consistent returns (Azure#13245)
  [text analytics] return None for offset and length for v3.0 (Azure#13382)
  edit all authentication files and add a test (Azure#13355)
  Add managed_identity_client_id argument to DefaultAzureCredential (Azure#13218)
  [text analytics] add string-index-type support (Azure#13378)
  [text analytics] fix error response if pii entities is called from v3.0 client (Azure#13383)
  Send spec (Azure#13143)
  Anomaly Detector 3.0.0b2 release (Azure#13351)
  ...
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 29, 2021
Dev sql microsoft.sql 2020 11 01 preview minor change (Azure#13689)

* Adds base for updating Microsoft.Sql from version preview/2020-08-01-preview to version 2020-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add updated 2020-11-01-preview versions of LongTermRetenionBackups.json and Databases.json (Azure#12146)

* add updated databases.json swagger

* update readme with new package

* v4 -> v5

* add missing chunk in readme

* add correct swaggeR

* add examples

* add correct examplese

* remove unreferenced examples

* update swagger and examples. add 2020-11 pure package

* Fix reference to 2020-08-01 reference to ElasticPools.json

* update Databases.json name

* update examples

* remove nonexistant swagger

* fixed reference capitals in readme

* update package composite and fix ref to ManagedInstances.jsON

* make backupstorageredundancy settings consistent

* add requestedBackupStorageRedundancy to properties object in example

* add LTR swagger and examples

* add LTR Policies swagger and examples

* make v5 match v4

* add updated Databses.json

* merge conflicts in LTR Policies swagger'

* take out comments in readme

* taking ImportExport.json out from 2020-11 package

* remove duplicate 2020-11 tag in readme

* modify Databases_legacy.json to exclude ImportExport-related APIs

* add servers.json for IE APIS and remove unused databases examples

* fix model & prettier errors; add missing server example

* add missing servers examples

* fix example to exclude property from server obj

* change RecommendedActions definitoins

* change tag to composite v4

* Add missing properties for api version 2020-02-02-preview of securityAlertPolicies (Azure#13117)

* Add missing properties for api version 2020-02-02-preview

* fix checks

* fix according to prettier check

* Add the change to version 2020-08-01-preview and version 2020-11-01-preview

* remove changes in package-lock

* Add new line at the end of file

* update version 2020-11-01-preview

* Update the ref to system data in serverdevopsaudit

* add missing point

* fix the validation errors

* Delete ServerDevOpsAudit.json

* fix the validation errors

* re add ServerDevOpsAudit.json

* fix the validation errors (Azure#13325)

* fix the validation errors

* Delete ServerDevOpsAudit.json

* fix the validation errors

* re add ServerDevOpsAudit.json

* address PrivateEndpointConnections.json validation issues in v3, v2 and v1

* Address Private Endpoint validation issues in V3, V2 and V1 SDK tags (Azure#13404)

* fix the validation errors

* Delete ServerDevOpsAudit.json

* fix the validation errors

* re add ServerDevOpsAudit.json

* address PrivateEndpointConnections.json validation issues in v3, v2 and v1

* Identity/Key/external Admin API (Azure#13411)

* Add examples for sql mi remove maintenance configuration (Azure#13390)

* Add missing specs 2020 11 01 (Azure#13488)

* fix the validation errors

* Delete ServerDevOpsAudit.json

* fix the validation errors

* re add ServerDevOpsAudit.json

* address PrivateEndpointConnections.json validation issues in v3, v2 and v1

* add missing specs in 2020-11-01-preview

* update the validation errors

* update systemData and sync with global common/v1/types.json

* update legacy to match the latest database specs

* remove RestorableDroppedManagedInstances due to it should be internal

* Updated database extensions (Azure#13584)

Co-authored-by: Geetha Athreya <geathrey@microsoft.com>

Co-authored-by: xaliciayang <59986952+xaliciayang@users.noreply.github.com>
Co-authored-by: ayeletshpigelman <ayshpige@microsoft.com>
Co-authored-by: strehan1993 <70013163+strehan1993@users.noreply.github.com>
Co-authored-by: Ivan Kulezic <72797230+kukislav@users.noreply.github.com>
Co-authored-by: Geetha Athreya <43223869+athreya-geetha@users.noreply.github.com>
Co-authored-by: Geetha Athreya <geathrey@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants