Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating sample for beta2 api #18711

Merged
merged 1 commit into from
May 17, 2021
Merged

updating sample for beta2 api #18711

merged 1 commit into from
May 17, 2021

Conversation

seankane-msft
Copy link
Member

closes #18657

@seankane-msft seankane-msft requested a review from annelo-msft May 13, 2021 15:21
@seankane-msft seankane-msft self-assigned this May 13, 2021
@seankane-msft seankane-msft requested a review from benbp as a code owner May 13, 2021 15:21
@ghost ghost added the Container Registry label May 13, 2021
annelo-msft
annelo-msft approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks! Possibly worth getting Python dev eyes on, per your judgment.

@seankane-msft seankane-msft requested a review from swathipil May 13, 2021 17:39
swathipil
swathipil approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question but LGTM

...ontainerregistry/azure-containerregistry/samples/async_samples/sample_create_client_async.py
# [END create_registry_client]

async def create_repository_client(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you move the creating repository client sample elsewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This object isn't meant to be instantiated directly so I removed the sample

@seankane-msft seankane-msft merged commit fb9747d into Azure:master May 17, 2021
@seankane-msft seankane-msft deleted the acr-update-sample branch May 17, 2021 18:19
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request May 18, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
068b134 
…into switch_to_westus_2

* 'master' of https://github.com/Azure/azure-sdk-for-python: (28 commits)
  Add Testing of Conda Artifacts (Azure#18478)
  reset continuation token (Azure#18772)
  pipline prepare (Azure#18755)
  [AutoRelease] t2-machinelearningcompute-2021-05-14-14426(wave4) (Azure#18750)
  [AutoRelease] t2-iothubprovisioningservices-2021-05-14-29542(wave4) (Azure#18748)
  [AutoRelease] t2-agfood-2021-05-17-53436 (Azure#18768)
  unskip custom form tests - unlabeled table bounding box regression fixed (Azure#18776)
  [Tables] test cleanup (Azure#18676)
  adding mindependency to the default set of PR tests (Azure#18775)
  updating sample for beta2 api (Azure#18711)
  useless folder del (Azure#18771)
  [AutoRelease] t2-recoveryservicesbackup-2021-05-14-03506(wave4) (Azure#18749)
  [AutoRelease] t2-network-2021-05-14-21408(Do not merge) (Azure#18746)
  [AutoRelease] t2-iothub-2021-05-14-97452 (Azure#18753)
  Rename to AZURE_PHONE_NUMBER (Azure#18760)
  [Communication]: Removed tests.yml file for single pipeline (Azure#18684)
  [Storage][ChangeLog]STG77 Changelog (Azure#18678)
  [Communication]: Added unit tests to check if idempotence parameters are being set (Azure#18739)
  allow multiple invocations of archetype-sdk-tests-generate (Azure#18759)
  [Media] Ava sdk update (Azure#18359)
  ...
iscai-msft added a commit to agniveshadhikari/azure-sdk-for-python that referenced this pull request May 18, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
bd0c884 
…into agrifood/test-infra

* 'master' of https://github.com/Azure/azure-sdk-for-python: (33 commits)
  Increment version for textanalytics releases (Azure#18797)
  remove PHI with multiple actions due to known service error (Azure#18794)
  [textanalyitcs] switch to westus2 region (Azure#18791)
  Remove implicit dependency on successful completion of verify-links (Azure#18277)
  Add Testing of Conda Artifacts (Azure#18478)
  reset continuation token (Azure#18772)
  pipline prepare (Azure#18755)
  [AutoRelease] t2-machinelearningcompute-2021-05-14-14426(wave4) (Azure#18750)
  [AutoRelease] t2-iothubprovisioningservices-2021-05-14-29542(wave4) (Azure#18748)
  [AutoRelease] t2-agfood-2021-05-17-53436 (Azure#18768)
  unskip custom form tests - unlabeled table bounding box regression fixed (Azure#18776)
  [Tables] test cleanup (Azure#18676)
  adding mindependency to the default set of PR tests (Azure#18775)
  updating sample for beta2 api (Azure#18711)
  useless folder del (Azure#18771)
  [AutoRelease] t2-recoveryservicesbackup-2021-05-14-03506(wave4) (Azure#18749)
  [AutoRelease] t2-network-2021-05-14-21408(Do not merge) (Azure#18746)
  [AutoRelease] t2-iothub-2021-05-14-97452 (Azure#18753)
  Rename to AZURE_PHONE_NUMBER (Azure#18760)
  [Communication]: Removed tests.yml file for single pipeline (Azure#18684)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swathipil swathipil swathipil approved these changes

@annelo-msft annelo-msft annelo-msft approved these changes

@benbp benbp Awaiting requested review from benbp

Assignees

@seankane-msft seankane-msft

Labels
Container Registry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update sample_create_client.py for Beta 3 API
3 participants
@seankane-msft @annelo-msft @swathipil