[Communication]: Added unit tests to check if idempotence parameters are being set #18739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run python - azure-communication-sms - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - azure-communication-sms - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lsundaralingam
requested review from
ankitarorabit,
memontic-ms and
a team
as code owners
|
These are good, but is there a way to test the repeatabilityResponse coming back from the server as well? that's what we're testing in Java/.Net/JS |
There doesn't seem to be way in Python to get the raw HTTP response back in the live tests like we do for the other languages, butI don't see anything that we're missing here in terms of test coverage. We have live tests that would fail if there's something wrong with the repeatabilityResponse and we have these tests to ensure that the parameters are being set. |
beltr0n
approved these changes
May 14, 2021
jbeauregardb
approved these changes
May 14, 2021
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
May 18, 2021
…into switch_to_westus_2 * 'master' of https://github.com/Azure/azure-sdk-for-python: (28 commits) Add Testing of Conda Artifacts (Azure#18478) reset continuation token (Azure#18772) pipline prepare (Azure#18755) [AutoRelease] t2-machinelearningcompute-2021-05-14-14426(wave4) (Azure#18750) [AutoRelease] t2-iothubprovisioningservices-2021-05-14-29542(wave4) (Azure#18748) [AutoRelease] t2-agfood-2021-05-17-53436 (Azure#18768) unskip custom form tests - unlabeled table bounding box regression fixed (Azure#18776) [Tables] test cleanup (Azure#18676) adding mindependency to the default set of PR tests (Azure#18775) updating sample for beta2 api (Azure#18711) useless folder del (Azure#18771) [AutoRelease] t2-recoveryservicesbackup-2021-05-14-03506(wave4) (Azure#18749) [AutoRelease] t2-network-2021-05-14-21408(Do not merge) (Azure#18746) [AutoRelease] t2-iothub-2021-05-14-97452 (Azure#18753) Rename to AZURE_PHONE_NUMBER (Azure#18760) [Communication]: Removed tests.yml file for single pipeline (Azure#18684) [Storage][ChangeLog]STG77 Changelog (Azure#18678) [Communication]: Added unit tests to check if idempotence parameters are being set (Azure#18739) allow multiple invocations of archetype-sdk-tests-generate (Azure#18759) [Media] Ava sdk update (Azure#18359) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.