Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication]: Updated swagger paths #18839

Merged
merged 1 commit into from
May 26, 2021

Conversation

lsundaralingam
Copy link
Member

No description provided.

@ghost ghost added the Communication label May 20, 2021
@lsundaralingam
Copy link
Member Author

/azp run python - azure-communication-phonenumbers - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lsundaralingam
Copy link
Member Author

/azp run python - azure-communication-sms - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lsundaralingam
Copy link
Member Author

/azp run python - azure-communication-identity - tests

@lsundaralingam
Copy link
Member Author

/azp run python - azure-communication-chat - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lsundaralingam lsundaralingam marked this pull request as ready for review May 20, 2021 23:48
Copy link
Member

@JoshuaLai JoshuaLai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the swaggers looks good. I am not sure why there is added casting to Any but I assume it is an autorest version change? The one thing that does look concerning is the polling from false to true. I would leave that to a Python expert to comment on.

@jbeauregardb
Copy link
Contributor

jbeauregardb commented May 26, 2021

@JoshuaLai I don't know if that change was deliberate, but from a customer perspective I think polling being set to True as default is a better choice. @lsundaralingam If the polling kwarg is being set to True as default... Should we change our tests code to remove the kwarg from the function call? It shouldn't be required anymore. On the other side, I don't know if this change was deliberate and they may change it back.

@lsundaralingam
Copy link
Member Author

@JoshuaLai I don't know if that change was deliberate, but from a customer perspective I think polling being set to True as default is a better choice. @lsundaralingam If the polling kwarg is being set to True as default... Should we change our tests code to remove the kwarg from the function call? It shouldn't be required anymore. On the other side, I don't know if this change was deliberate and they may change it back.

I discussed with @jbeauregardb offline and we decided on keeping the kwarg since it's safer to always pass in the parameter.

@JoshuaLai
Copy link
Member

JoshuaLai commented May 26, 2021

@JoshuaLai I don't know if that change was deliberate, but from a customer perspective I think polling being set to True as default is a better choice. @lsundaralingam If the polling kwarg is being set to True as default... Should we change our tests code to remove the kwarg from the function call? It shouldn't be required anymore. On the other side, I don't know if this change was deliberate and they may change it back.

I discussed with @jbeauregardb offline and we decided on keeping the kwarg since it's safer to always pass in the parameter.

Awesome! Does that mean this is safe to merge in now?

@lsundaralingam lsundaralingam merged commit 0014fef into Azure:master May 26, 2021
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Jun 1, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request May 5, 2022
Correct Probe enums (Azure#18839)

* fix probe enums

* Fix revision mode enum

* Fix patch example
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Sep 22, 2022
Merge Microsoft.app 2022 06 01 preview to main (Azure#20787)

* Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01

* Updates readme

* Updates API version in new specs and examples

* Add app diag to 2022-05-01 (Azure#18678)

* Add container apps diagnostics

* Fix validation errors

* Move Microsoft.App diag APIs to 2022-05-01

* Fix validation errors

* Fix validation errors

* Fix validation errors 3

* Change operationIds

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Fix definition for customhostnameesult (Azure#19014)

* fix

* update

* more fix

* Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048)

* Correct Probe enums (Azure#18839)

* fix probe enums

* Fix revision mode enum

* Fix patch example

* Fix the casing of enums in the latest api version

* Change the parameter names to unblock Terraform release (Azure#19005)

* contianerapps: fixing swagger inconsistencies in 2022-01-01-preview

* containerapps: fixing inconsistencies in the 2022-03-01 swagger

* containerapps: updating the examples for 2022-01-01-preview

* containerapps: updating the examples to account for the updated parameter names

* containerapps: fixing linting

* fix probe enums

* Fix revision mode enum

* Fix the policheck error

* Revert "containerapps: fixing linting"

This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8.

* Revert "containerapps: updating the examples for 2022-01-01-preview"

This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c.

* Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview"

This reverts commit 553fc551b3239598157238ed6246085748421b87.

* Undo changes to 2022-01-01-preview

* Fix one issue

* fix remaining inconsistency

* fix authConfig and sourceControl names

Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Mike Vu <mikevu@microsoft.com>

* Change param names

* Fix examples

* Fix CI errors

Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>

* Fix description in all API versions (Azure#19313)

* Fix description for ManagedEnvironment.Internal property (Azure#19307)

* Fix descriptions in all api versions

* Add traffic info to revisions api (Azure#19054)

* Add traffic info to a revision api

* Add deprecated prop

* Prettier fixes

* 1pdate based on new proposal

* Rename

* Change names

* minor fix

* Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360)

* Add httpReadBufferSize to dapr config

* remove nullable

* Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add new resources for 2022-06-01-preview (Azure#19494)

* update

* update

* update

* fix

* update

* update

* update

* update

* fix

* update

* update

* Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974)

* Enable Dapr AI Connection string for Microsoft.App connected environment

* Fix dapr ai connection string

* remove read

* remove read permission of dapr ai connection string and instrument key for managed environment

* fixes for comments

* update (Azure#20013)

* Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133)

* Fix casing for detector properties

* Fix descriptions

* Fix descriptions and detectorProperties in 2022-06-01-preview

* Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044)

* Added `secretsStoreComponent` in 2022-06-01 spec

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Fixed typos and added example of name/key

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Add custom domain configuration for managed environment (Azure#20149)

Co-authored-by: Mengjun Qin <menqin@microsoft.com>

* Add additional Dapr options (2022-06-01-preview) (Azure#19886)

* Add additional Dapr options

* Update examples for 2022-06-01-preview

* force ci

* force ci

* force ci

* adding ip-restriction feat (Azure#19841)

* adding ip-restriction feat

* remove from stable, add to preview

* fix lintDiff error

* fix modelvalidation error

* fix formatting changes

* rename names, add note to all allow or all deny

* fix spell check error

* update name and examples

* rename `ipAddress` to `ipAddressRange`

* making small change to re-run build pipeline

* trigger GitHub actions

* resolve comments

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>

* Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261)

* Revert "Add traffic info to revisions api (Azure#19054)"

This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b.

* Remove traffic labels from revisions

* Add property for tcp apps (Azure#20193)

* Add property for tcp apps

* Add scale

* Fix

* Fix

* Add Init Containers to common definitions (Azure#19855)

* add init containers to common definitions

* move changes to 06-01 preview

* remove repeated container definition

* fix allof syntax

* fix anonymous container definition

* fix lintdiff errors

* fix container allof syntax

* add more init examples

* split baseContainer definition

* remove description

Co-authored-by: p-bouchon <pbouchon@microsoft.com>

* Update container app provisioningstate (Azure#20411)

* update

* update

* add property: maxInactiveRevisions (Azure#20334)

* add property: maxInactiveRevisions

* update

* update

* Add premium sku related properties for managed environment (Azure#19770)

* Add premium sku related properties for managed environment

* Move sku to base property

* Add workloadProfileType

* Examples for managed environment

* Add container app example

* Fix workloadProfiles

* Add custom word

* Fix WorkloadProfileType references

* prettier fixes

* Fix workload profile

* Fix typo

* remove readonly property for workload profile

* Add object type

* nit: Fix description location

* Fix XmsIdentifierValidation

* Remove spaces from enum values

* Remove unwanted change

* Add aka ms url

* Update examples for workload profile type

* Fix rebase issue

* Fix json

* Update description and move location

* Remove provisioning state for node pool

* sku capacity explanation

* Remove capacity attribute

* Remove capacity attribute from required

* Mark sku property as required

* Add x-ms-identifiers

* Rename mimum and maximum

* Rename skutype to skuName

* Make sku property as optional

* Make workload profile type as string

* fix go SDK automation config

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Fix source control status code in 2022-06-01-preview. (Azure#20429)

* Remove 20220501 because we will not support it in server side (Azure#20427)

* remove

* update

* Added support for user defined routing (Azure#20464)

* Added support for user defined routing

* Added examples

* fixed JSON syntax

* syntax fix

* fixed vnetenvironment syntax

* fixed camel case

* case fix

* enum syntax

* fixed comma cases ManagedEnvironmentOutBoundType

* fixing casing

* Some more APIs (Azure#20448)

* new APIs to 06-01

* test fix

* more fixes

* add last active time for revision (Azure#20658)

* Add custom domain for connected env (Azure#20731)

* add custom domain

* fhcekout

* billingMeters - GET endpoint (Azure#20485)

* Swagger documentation for /locations/{location}/billingMeters - GET endpoint

* Add example, fix validation errors

* Fix ARM validation errors, code review comments

* Fix response validation

* add proxy resource properties

* Response formatting

* add default error response

* ARM Review feedback + small naming change for a property

* Change GB to GiB

* Fix 2022-06-01-preview branch merge conflicts (Azure#20773)

* Reset

* more fixes

* More fixes

* another conflict fix

* Fix old preview version

* fix 2022-03-01

* supress lint

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com>
Co-authored-by: michimune <michimune@outlook.com>
Co-authored-by: Michimune Kohno <mikono@microsoft.com>
Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Mengjun Qin <767524684@qq.com>
Co-authored-by: Mengjun Qin <menqin@microsoft.com>
Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com>
Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com>
Co-authored-by: p-bouchon <pbouchon@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: JJ <jijohn@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com>
Co-authored-by: Mahmoud Desokey <desokey@yahoo.com>
Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com>
Co-authored-by: trajkobal <108365738+trajkobal@users.noreply.github.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Sep 27, 2022
Rename Post Action and Add Secrets Tags (Azure#20775)

* Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01

* Updates readme

* Updates API version in new specs and examples

* Add app diag to 2022-05-01 (Azure#18678)

* Add container apps diagnostics

* Fix validation errors

* Move Microsoft.App diag APIs to 2022-05-01

* Fix validation errors

* Fix validation errors

* Fix validation errors 3

* Change operationIds

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Fix definition for customhostnameesult (Azure#19014)

* fix

* update

* more fix

* Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048)

* Correct Probe enums (Azure#18839)

* fix probe enums

* Fix revision mode enum

* Fix patch example

* Fix the casing of enums in the latest api version

* Change the parameter names to unblock Terraform release (Azure#19005)

* contianerapps: fixing swagger inconsistencies in 2022-01-01-preview

* containerapps: fixing inconsistencies in the 2022-03-01 swagger

* containerapps: updating the examples for 2022-01-01-preview

* containerapps: updating the examples to account for the updated parameter names

* containerapps: fixing linting

* fix probe enums

* Fix revision mode enum

* Fix the policheck error

* Revert "containerapps: fixing linting"

This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8.

* Revert "containerapps: updating the examples for 2022-01-01-preview"

This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c.

* Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview"

This reverts commit 553fc551b3239598157238ed6246085748421b87.

* Undo changes to 2022-01-01-preview

* Fix one issue

* fix remaining inconsistency

* fix authConfig and sourceControl names

Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Mike Vu <mikevu@microsoft.com>

* Change param names

* Fix examples

* Fix CI errors

Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>

* Fix description in all API versions (Azure#19313)

* Fix description for ManagedEnvironment.Internal property (Azure#19307)

* Fix descriptions in all api versions

* Add traffic info to revisions api (Azure#19054)

* Add traffic info to a revision api

* Add deprecated prop

* Prettier fixes

* 1pdate based on new proposal

* Rename

* Change names

* minor fix

* Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360)

* Add httpReadBufferSize to dapr config

* remove nullable

* Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add new resources for 2022-06-01-preview (Azure#19494)

* update

* update

* update

* fix

* update

* update

* update

* update

* fix

* update

* update

* Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974)

* Enable Dapr AI Connection string for Microsoft.App connected environment

* Fix dapr ai connection string

* remove read

* remove read permission of dapr ai connection string and instrument key for managed environment

* fixes for comments

* update (Azure#20013)

* Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133)

* Fix casing for detector properties

* Fix descriptions

* Fix descriptions and detectorProperties in 2022-06-01-preview

* Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044)

* Added `secretsStoreComponent` in 2022-06-01 spec

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Fixed typos and added example of name/key

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Add custom domain configuration for managed environment (Azure#20149)

Co-authored-by: Mengjun Qin <menqin@microsoft.com>

* Add additional Dapr options (2022-06-01-preview) (Azure#19886)

* Add additional Dapr options

* Update examples for 2022-06-01-preview

* force ci

* force ci

* force ci

* adding ip-restriction feat (Azure#19841)

* adding ip-restriction feat

* remove from stable, add to preview

* fix lintDiff error

* fix modelvalidation error

* fix formatting changes

* rename names, add note to all allow or all deny

* fix spell check error

* update name and examples

* rename `ipAddress` to `ipAddressRange`

* making small change to re-run build pipeline

* trigger GitHub actions

* resolve comments

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>

* Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261)

* Revert "Add traffic info to revisions api (Azure#19054)"

This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b.

* Remove traffic labels from revisions

* Add property for tcp apps (Azure#20193)

* Add property for tcp apps

* Add scale

* Fix

* Fix

* Add Init Containers to common definitions (Azure#19855)

* add init containers to common definitions

* move changes to 06-01 preview

* remove repeated container definition

* fix allof syntax

* fix anonymous container definition

* fix lintdiff errors

* fix container allof syntax

* add more init examples

* split baseContainer definition

* remove description

Co-authored-by: p-bouchon <pbouchon@microsoft.com>

* Update container app provisioningstate (Azure#20411)

* update

* update

* add property: maxInactiveRevisions (Azure#20334)

* add property: maxInactiveRevisions

* update

* update

* Add premium sku related properties for managed environment (Azure#19770)

* Add premium sku related properties for managed environment

* Move sku to base property

* Add workloadProfileType

* Examples for managed environment

* Add container app example

* Fix workloadProfiles

* Add custom word

* Fix WorkloadProfileType references

* prettier fixes

* Fix workload profile

* Fix typo

* remove readonly property for workload profile

* Add object type

* nit: Fix description location

* Fix XmsIdentifierValidation

* Remove spaces from enum values

* Remove unwanted change

* Add aka ms url

* Update examples for workload profile type

* Fix rebase issue

* Fix json

* Update description and move location

* Remove provisioning state for node pool

* sku capacity explanation

* Remove capacity attribute

* Remove capacity attribute from required

* Mark sku property as required

* Add x-ms-identifiers

* Rename mimum and maximum

* Rename skutype to skuName

* Make sku property as optional

* Make workload profile type as string

* fix go SDK automation config

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Fix source control status code in 2022-06-01-preview. (Azure#20429)

* Remove 20220501 because we will not support it in server side (Azure#20427)

* remove

* update

* Added support for user defined routing (Azure#20464)

* Added support for user defined routing

* Added examples

* fixed JSON syntax

* syntax fix

* fixed vnetenvironment syntax

* fixed camel case

* case fix

* enum syntax

* fixed comma cases ManagedEnvironmentOutBoundType

* fixing casing

* Some more APIs (Azure#20448)

* new APIs to 06-01

* test fix

* more fixes

* add last active time for revision (Azure#20658)

* Add custom domain for connected env (Azure#20731)

* add custom domain

* fhcekout

* billingMeters - GET endpoint (Azure#20485)

* Swagger documentation for /locations/{location}/billingMeters - GET endpoint

* Add example, fix validation errors

* Fix ARM validation errors, code review comments

* Fix response validation

* add proxy resource properties

* Response formatting

* add default error response

* ARM Review feedback + small naming change for a property

* Change GB to GiB

* Rename Action

* secrets tag

* missed fix

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com>
Co-authored-by: michimune <michimune@outlook.com>
Co-authored-by: Michimune Kohno <mikono@microsoft.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Mengjun Qin <767524684@qq.com>
Co-authored-by: Mengjun Qin <menqin@microsoft.com>
Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com>
Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com>
Co-authored-by: p-bouchon <pbouchon@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: JJ <jijohn@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com>
Co-authored-by: Mahmoud Desokey <desokey@yahoo.com>
Co-authored-by: trajkobal <108365738+trajkobal@users.noreply.github.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Sep 28, 2022
Availableworkloadprofiles - GET endpoint (Azure#20650)

* Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01

* Updates readme

* Updates API version in new specs and examples

* Add app diag to 2022-05-01 (Azure#18678)

* Add container apps diagnostics

* Fix validation errors

* Move Microsoft.App diag APIs to 2022-05-01

* Fix validation errors

* Fix validation errors

* Fix validation errors 3

* Change operationIds

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Fix definition for customhostnameesult (Azure#19014)

* fix

* update

* more fix

* Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048)

* Correct Probe enums (Azure#18839)

* fix probe enums

* Fix revision mode enum

* Fix patch example

* Fix the casing of enums in the latest api version

* Change the parameter names to unblock Terraform release (Azure#19005)

* contianerapps: fixing swagger inconsistencies in 2022-01-01-preview

* containerapps: fixing inconsistencies in the 2022-03-01 swagger

* containerapps: updating the examples for 2022-01-01-preview

* containerapps: updating the examples to account for the updated parameter names

* containerapps: fixing linting

* fix probe enums

* Fix revision mode enum

* Fix the policheck error

* Revert "containerapps: fixing linting"

This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8.

* Revert "containerapps: updating the examples for 2022-01-01-preview"

This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c.

* Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview"

This reverts commit 553fc551b3239598157238ed6246085748421b87.

* Undo changes to 2022-01-01-preview

* Fix one issue

* fix remaining inconsistency

* fix authConfig and sourceControl names

Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Mike Vu <mikevu@microsoft.com>

* Change param names

* Fix examples

* Fix CI errors

Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>

* Fix description in all API versions (Azure#19313)

* Fix description for ManagedEnvironment.Internal property (Azure#19307)

* Fix descriptions in all api versions

* Add traffic info to revisions api (Azure#19054)

* Add traffic info to a revision api

* Add deprecated prop

* Prettier fixes

* 1pdate based on new proposal

* Rename

* Change names

* minor fix

* Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360)

* Add httpReadBufferSize to dapr config

* remove nullable

* Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add new resources for 2022-06-01-preview (Azure#19494)

* update

* update

* update

* fix

* update

* update

* update

* update

* fix

* update

* update

* Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974)

* Enable Dapr AI Connection string for Microsoft.App connected environment

* Fix dapr ai connection string

* remove read

* remove read permission of dapr ai connection string and instrument key for managed environment

* fixes for comments

* update (Azure#20013)

* Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133)

* Fix casing for detector properties

* Fix descriptions

* Fix descriptions and detectorProperties in 2022-06-01-preview

* Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044)

* Added `secretsStoreComponent` in 2022-06-01 spec

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Fixed typos and added example of name/key

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Add custom domain configuration for managed environment (Azure#20149)

Co-authored-by: Mengjun Qin <menqin@microsoft.com>

* Add additional Dapr options (2022-06-01-preview) (Azure#19886)

* Add additional Dapr options

* Update examples for 2022-06-01-preview

* force ci

* force ci

* force ci

* adding ip-restriction feat (Azure#19841)

* adding ip-restriction feat

* remove from stable, add to preview

* fix lintDiff error

* fix modelvalidation error

* fix formatting changes

* rename names, add note to all allow or all deny

* fix spell check error

* update name and examples

* rename `ipAddress` to `ipAddressRange`

* making small change to re-run build pipeline

* trigger GitHub actions

* resolve comments

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>

* Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261)

* Revert "Add traffic info to revisions api (Azure#19054)"

This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b.

* Remove traffic labels from revisions

* Add property for tcp apps (Azure#20193)

* Add property for tcp apps

* Add scale

* Fix

* Fix

* Add Init Containers to common definitions (Azure#19855)

* add init containers to common definitions

* move changes to 06-01 preview

* remove repeated container definition

* fix allof syntax

* fix anonymous container definition

* fix lintdiff errors

* fix container allof syntax

* add more init examples

* split baseContainer definition

* remove description

Co-authored-by: p-bouchon <pbouchon@microsoft.com>

* Update container app provisioningstate (Azure#20411)

* update

* update

* add property: maxInactiveRevisions (Azure#20334)

* add property: maxInactiveRevisions

* update

* update

* Add premium sku related properties for managed environment (Azure#19770)

* Add premium sku related properties for managed environment

* Move sku to base property

* Add workloadProfileType

* Examples for managed environment

* Add container app example

* Fix workloadProfiles

* Add custom word

* Fix WorkloadProfileType references

* prettier fixes

* Fix workload profile

* Fix typo

* remove readonly property for workload profile

* Add object type

* nit: Fix description location

* Fix XmsIdentifierValidation

* Remove spaces from enum values

* Remove unwanted change

* Add aka ms url

* Update examples for workload profile type

* Fix rebase issue

* Fix json

* Update description and move location

* Remove provisioning state for node pool

* sku capacity explanation

* Remove capacity attribute

* Remove capacity attribute from required

* Mark sku property as required

* Add x-ms-identifiers

* Rename mimum and maximum

* Rename skutype to skuName

* Make sku property as optional

* Make workload profile type as string

* fix go SDK automation config

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Fix source control status code in 2022-06-01-preview. (Azure#20429)

* Swagger documentation for /locations/{location}/billingMeters - GET endpoint

* Add example, fix validation errors

* Fix ARM validation errors, code review comments

* Fix response validation

* Remove 20220501 because we will not support it in server side (Azure#20427)

* remove

* update

* add proxy resource properties

* Response formatting

* Added support for user defined routing (Azure#20464)

* Added support for user defined routing

* Added examples

* fixed JSON syntax

* syntax fix

* fixed vnetenvironment syntax

* fixed camel case

* case fix

* enum syntax

* fixed comma cases ManagedEnvironmentOutBoundType

* fixing casing

* add default error response

* Add available workprofiles -GET endpoint

* Remove duplicate schema name WorkloadProfile

* Change memoryGiB to memoryGB as suggested in code review

* Add x-ms-pageable - nextLink support to not introduce breaking changes in the future

* rename to memory in GiB because our case is Gibibytes base 1024

* change friendlyName to displayName

* Some more APIs (Azure#20448)

* new APIs to 06-01

* test fix

* more fixes

* Add new property to the response object

* add last active time for revision (Azure#20658)

* Add custom domain for connected env (Azure#20731)

* add custom domain

* fhcekout

* billingMeters - GET endpoint (Azure#20485)

* Swagger documentation for /locations/{location}/billingMeters - GET endpoint

* Add example, fix validation errors

* Fix ARM validation errors, code review comments

* Fix response validation

* add proxy resource properties

* Response formatting

* add default error response

* ARM Review feedback + small naming change for a property

* Change GB to GiB

* Change the boolean value for default to enum

* change error response to v3/ErrorResponse

* Fix 2022-06-01-preview branch merge conflicts (Azure#20773)

* Reset

* more fixes

* More fixes

* another conflict fix

* Fix old preview version

* fix 2022-03-01

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com>
Co-authored-by: michimune <michimune@outlook.com>
Co-authored-by: Michimune Kohno <mikono@microsoft.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Mengjun Qin <767524684@qq.com>
Co-authored-by: Mengjun Qin <menqin@microsoft.com>
Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com>
Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com>
Co-authored-by: p-bouchon <pbouchon@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: JJ <jijohn@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com>
Co-authored-by: Mahmoud Desokey <desokey@yahoo.com>
Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants