-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[textanalytics] adds extractive summarization action #19824
Merged
kristapratico
merged 19 commits into
Azure:feature/TA-v3.2-preview.1
from
kristapratico:extractive-summarization
Jul 26, 2021
Merged
[textanalytics] adds extractive summarization action #19824
kristapratico
merged 19 commits into
Azure:feature/TA-v3.2-preview.1
from
kristapratico:extractive-summarization
Jul 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
deyaaeldeen
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was fast! Looking good!
kristapratico
commented
Jul 23, 2021
sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py
Show resolved
Hide resolved
kristapratico
commented
Jul 23, 2021
sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py
Show resolved
Hide resolved
iscai-msft
approved these changes
Jul 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, and I like how you didn't have to add too much code!
sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py
Show resolved
Hide resolved
sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py
Show resolved
Hide resolved
maririos
reviewed
Jul 23, 2021
maririos
reviewed
Jul 23, 2021
maririos
approved these changes
Jul 23, 2021
kristapratico
added a commit
that referenced
this pull request
Aug 4, 2021
* [textanalytics] regenerate v3.2-preview.1 (#19805) * update swagger readme * regenerate code for v3.2-preview.1 * fixes for hooking up convenience layer to generated layer * remove unnecessary check * [textanalytics] adds extractive summarization action (#19824) * update swagger readme * regenerate code for v3.2-preview.1 * fixes for hooking up convenience layer to generated layer * add support for extract summary action * align naming * missed one * readme and changelog * fixing docstrings * add some extract summary action tests * update sync/async sample to include summary action * fix disable_service_logs default * test rank score * add bug fix to changelog * add missing reprs to new models * add test for extract summary partial results * update changelog to specify API version now targeting * regen on latest swagger * target swagger in repo and fix sample docs whitespace * remove support for python 3.5 (#19913) * [textanalytics] add extractive summarization samples (#20010) * add extractive summarization samples * wording * [textanalytics] rerecord tests (#20045) * rerecord everything but healthcare * linting * rerecord healthcare tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19800
https://apiview.dev/Assemblies/Review/f74ef8c4777b408f85dab76b8034cb41?diffRevisionId=5ad3e66d03b7475f984435bcb8dabd25&doc=False&diffOnly=True
Will add more tests in a later PR.