Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dummy values and correct code rendering in README #20322

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Use dummy values and correct code rendering in README #20322

merged 2 commits into from
Aug 31, 2021

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Aug 17, 2021

This uses dummy values for a code snippet connection string to resolve a CredScan warning over a fake SAS key. Also, code snippets have been marked as Python code to render colorfully.

@mccoyp mccoyp added Docs IoT Client This issue points to a problem in the data-plane of the library. labels Aug 17, 2021
@mccoyp mccoyp requested a review from giakas as a code owner August 17, 2021 21:47
@mccoyp mccoyp requested review from lmazuel and v-xuto August 17, 2021 21:48
@mccoyp mccoyp merged commit 8496bd8 into main Aug 31, 2021
@mccoyp mccoyp deleted the readme-fix branch August 31, 2021 17:39
iscai-msft added a commit that referenced this pull request Aug 31, 2021
…into header_tuples

* 'main' of https://github.com/Azure/azure-sdk-for-python: (21 commits)
  [Key Vault] Add 7.3-preview support for certificates (#20477)
  Use dummy values and correct code rendering in README (#20322)
  Use CredScan-suppressed dummy password in sample (#20468)
  Fix type annotation in azure.storage.blob (#20084)
  Adding static checks (#20457)
  release_iseus_status_auto_reply (#20441)
  Clarify LogsQueryClient query parameter description (#20467)
  Sync eng/common directory with azure-sdk-tools for PR 1953 (#20466)
  Skip eng common workflow enforcer for private repos (#20462)
  remove iter_text and iter_lines (#20460)
  [ServiceBus] Improve test stability and cpu usage (#20352)
  t2-Netapp-update-to-2021-06-01 (#20453)
  [AutoRelease] t2-keyvault-2021-08-26-55443 (#20423)
  Sync eng/common directory with azure-sdk-tools for PR 1943 (#20450)
  New dummy password in README (#20328)
  ensure test principal creation succeeds properly (#20446)
  Update question-answering readme links (#20439)
  Stip empty changelog sections before release (#20437)
  [AutoRelease] t2-healthcareapis-2021-08-26-27542 (#20422)
  [AutoRelease] t2-iothub-2021-08-25-25696 (#20409)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Aug 31, 2021
…into update_lro_paging

* 'main' of https://github.com/Azure/azure-sdk-for-python:
  [Core] Follow RFC 3339 datetime formatting for AzureJSONEncoder (Azure#20346)
  [Key Vault] Add 7.3-preview support for certificates (Azure#20477)
  Use dummy values and correct code rendering in README (Azure#20322)
  Use CredScan-suppressed dummy password in sample (Azure#20468)
  Fix type annotation in azure.storage.blob (Azure#20084)
  Adding static checks (Azure#20457)
  release_iseus_status_auto_reply (Azure#20441)
  Clarify LogsQueryClient query parameter description (Azure#20467)
  Sync eng/common directory with azure-sdk-tools for PR 1953 (Azure#20466)
  Skip eng common workflow enforcer for private repos (Azure#20462)
  remove iter_text and iter_lines (Azure#20460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Docs IoT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants