fix cspell issues for azure-communication identity #23085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
petrsvihlik
approved these changes
Feb 16, 2022
petrsvihlik
suggested changes
Feb 16, 2022
There was a problem hiding this comment.
how come the PR doesn't contain these?
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/user_credential_async.py:53:43 - Unknown word (inprogress)
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/user_credential_async.py:77:26 - Unknown word (inprogress)
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/user_credential.py:55:37 - Unknown word (inprogress)
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/user_credential.py:77:20 - Unknown word (inprogress)
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/policy.py:11:46 - Unknown word (IOHTTP)
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/policy.py:14:33 - Unknown word (IOHTTP)
These words were added by other teams |
danieljurek
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
cspell does not have a great way to determine word boundaries for collections of letters inside of things that are, to a human, obviously encoded values.
For future consideration: If you plan on changing these values frequently it might be easier to store the values in a separate file(s) and add those files to the list of files to ignore. Otherwise this method works well enough and will help you spot spelling errors in the rest of the tests.py file.
petrsvihlik
approved these changes
Feb 17, 2022
|
/check-enforcer evaluate |
AikoBB
deleted the
aigerimb/azure-communication-identity/fix_spell_issues
branch
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 4, 2022
…into new_metrics_advisor * 'main' of https://github.com/Azure/azure-sdk-for-python: (601 commits) pin markupsafe (Azure#23132) [Communication] - phone-numbers - Implement a phone number pool for update capabilities live tests (Azure#23116) Add timeout on Invoke-request call (Azure#23120) Sync eng/common directory with azure-sdk-tools for PR 2775 (Azure#23115) Update aggregate-report to use common credscan yml and update baseline file (Azure#23090) Update CHANGELOG.md (Azure#23119) [Issue helper] Update owner list (Azure#23079) [KV] Update changelogs for stable releases (Azure#23053) code and test (Azure#23047) [recoveryservicesbackup] fix multiple pages paging (Azure#23089) rerecord failing tests for fr (Azure#23107) [Test Proxy] Remove unnecessary git SHA fetch (Azure#23113) [Storage] Fix some mypy typing errors and typing imports (Azure#23098) Add logic to generate docs.ms ToC (Azure#23086) Fix broken link in tests.md (Azure#23110) Enable apistub gen step (Azure#23088) pin version of storage blob used for testing (Azure#23109) ensure that py36 can start the process properly (Azure#23108) fix cspell issues for azure-communication identity (Azure#22636) (Azure#23085) code and test (Azure#23077) ...
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
…re#23085) Co-authored-by: Aigerim Beishenbekova <aigerimb@Aigerims-MacBook-Pro-2.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed cspell issues for azure-communication identity
Resolves #22636
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines