Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cspell issues for azure-communication identity #23085

Conversation

AikoBB
Copy link
Member

@AikoBB AikoBB commented Feb 16, 2022

Description

Fixed cspell issues for azure-communication identity
Resolves #22636

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Communication label Feb 16, 2022
@petrsvihlik petrsvihlik enabled auto-merge (squash) February 16, 2022 14:40
@petrsvihlik petrsvihlik disabled auto-merge February 16, 2022 14:44
Copy link
Contributor

@petrsvihlik petrsvihlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come the PR doesn't contain these?

./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/user_credential_async.py:53:43 - Unknown word (inprogress)
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/user_credential_async.py:77:26 - Unknown word (inprogress)
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/user_credential.py:55:37 - Unknown word (inprogress)
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/user_credential.py:77:20 - Unknown word (inprogress)
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/policy.py:11:46 - Unknown word (IOHTTP)
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/policy.py:14:33 - Unknown word (IOHTTP)

@AikoBB
Copy link
Member Author

AikoBB commented Feb 16, 2022

how come the PR doesn't contain these?

./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/user_credential_async.py:53:43 - Unknown word (inprogress)
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/user_credential_async.py:77:26 - Unknown word (inprogress)
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/user_credential.py:55:37 - Unknown word (inprogress)
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/user_credential.py:77:20 - Unknown word (inprogress)
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/policy.py:11:46 - Unknown word (IOHTTP)
./sdk/communication/azure-communication-identity/azure/communication/identity/_shared/policy.py:14:33 - Unknown word (IOHTTP)

These words were added by other teams

Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cspell does not have a great way to determine word boundaries for collections of letters inside of things that are, to a human, obviously encoded values.

For future consideration: If you plan on changing these values frequently it might be easier to store the values in a separate file(s) and add those files to the list of files to ignore. Otherwise this method works well enough and will help you spot spelling errors in the rest of the tests.py file.

@petrsvihlik petrsvihlik enabled auto-merge (squash) February 17, 2022 08:07
@petrsvihlik
Copy link
Contributor

/check-enforcer evaluate

@petrsvihlik petrsvihlik merged commit 7faf310 into Azure:main Feb 17, 2022
@AikoBB AikoBB deleted the aigerimb/azure-communication-identity/fix_spell_issues branch February 17, 2022 10:45
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 4, 2022
…into new_metrics_advisor

* 'main' of https://github.com/Azure/azure-sdk-for-python: (601 commits)
  pin markupsafe (Azure#23132)
  [Communication] - phone-numbers - Implement a phone number pool for update capabilities live tests (Azure#23116)
  Add timeout on Invoke-request call (Azure#23120)
  Sync eng/common directory with azure-sdk-tools for PR 2775 (Azure#23115)
  Update aggregate-report to use common credscan yml and update baseline file (Azure#23090)
  Update CHANGELOG.md (Azure#23119)
  [Issue helper] Update owner list (Azure#23079)
  [KV] Update changelogs for stable releases (Azure#23053)
  code and test (Azure#23047)
  [recoveryservicesbackup] fix multiple pages paging (Azure#23089)
  rerecord failing tests for fr (Azure#23107)
  [Test Proxy] Remove unnecessary git SHA fetch (Azure#23113)
  [Storage] Fix some mypy typing errors and typing imports (Azure#23098)
  Add logic to generate docs.ms ToC (Azure#23086)
  Fix broken link in tests.md (Azure#23110)
  Enable apistub gen step (Azure#23088)
  pin version of storage blob used for testing (Azure#23109)
  ensure that py36 can start the process properly (Azure#23108)
  fix cspell issues for azure-communication identity (Azure#22636) (Azure#23085)
  code and test (Azure#23077)
  ...
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
…re#23085)

Co-authored-by: Aigerim Beishenbekova <aigerimb@Aigerims-MacBook-Pro-2.local>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Apr 18, 2023
Release machinelearningservices microsoft.machine learning services 2023 04 01 (Azure#23450)

* Adds base for updating Microsoft.MachineLearningServices from version stable/2022-10-01 to version 2023-04-01

* Updates readme

* Updates API version in new specs and examples

* [Stable] Bring Back schedule shutdown MLC models (Azure#23039)

* bring back schedule shutdown MLC models

* add description

---------

Co-authored-by: Naman Agarwal <naagarw@microsoft.com>

* add minLength:1 prop to required strings (Azure#23109)

* [Stable] Add IdleShutdown properties and api (Azure#23042)

* [Stable] Add IdleShutdown properties and api

* update version

* remove api to update IdleShutdownSetting

* Delete example

---------

Co-authored-by: Naman Agarwal <naagarw@microsoft.com>

* Pushing new features in stable swagger (Azure#23071)

* Pushing new features in stable swagger

* Added example file

* Triggering retest

* Fixed version issue

* Triggering retest

* Removing OS Patching

* Changes as per feedback, and add os patching back

* Fix formatting

* Removed Custom Service Update API

* Fixed Example Files

* Added as per review comments

* Added as per review comments

* Retrigger test

---------

Co-authored-by: Srivatsa Sinha <srsinha@microsoft.com>

* Add Registries 2023-04-01 Swagger (Azure#23085)

* add swagger + examples

* fix readme

* fix readme

* switching to autogenerated registries swagger

* fix spellcheck

* update ga examples

* previous API version for comparison = 2023-02-01-preview

* new API version for comparison = 2023-04-01

* update examples

* update swagger, examples to fix pr gates

* fix lint diff errors

* delete should have a 202 response, update createorupdate examples, fix removeRegions operation

* removeRegions -> LRO POST operation

* fix LRO options on removeRegions

* add registryNameParamert

* update swagger

* update

* PATCH property should have sku, identity properties

* fix example

---------

Co-authored-by: Komal Yadav <komalyadav@microsoft.com>

* MFE April 2023 staging (Azure#23164)

* add latest mfe.json

* updated examples

* add wasbs to known words

* swap pendingupload to proper naming

* align RPs on Azure Machine Learning Services

* rename pendingUpload to verb: startPendingUpload

* remove trailing slash startpendingupload

* improve descriptions

* add pattern to all resource name types + examples

* update original-uri -> azure-async-operation

* remove wasbs and mark credential usage as secret

* test is changing all to azure-async-operation causes breaking change

* the code is implemented where the original-uri is where you will find the final object post-polling

* update examples to remove wasbsUri

* reference registries instead for RegistryName

* remove wasbs

* original-uri -> azure-async-operation

* update examples to empty secrets

* CreateOrUpdatePendingUpload -> CreateOrUpdateStartPendingUpload

* add pattern for workspaceName

* x-ms-secret on the SASUri

* switch back to original-uri given update from auto-rest folks

---------

Co-authored-by: Kayla Ames <kaseager@microsoft.com>

* update compute examples to ReadOnly

* v5->v3

* PartialManagedServiceIdentity -> RegistryPartialManagedServiceIdentity

* update ID for delete/cancel job/schedule location header

* PrivateEndpointConnection -> RegistryPrivateEndpointConnection

* more renames for Registry

* align mlc with arm

* update registry examples

* update registryPrivateLinkServiceConnectionState in examples

* update description arm id for registryPrivateEndpointConnections

* update to preview

---------

Co-authored-by: Naman Agarwal <namanag16@gmail.com>
Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
Co-authored-by: Teddy Todorov <thtodoro@microsoft.com>
Co-authored-by: srivatsasinha <102133347+srivatsasinha@users.noreply.github.com>
Co-authored-by: Srivatsa Sinha <srsinha@microsoft.com>
Co-authored-by: Komal Yadav <23komal.yadav23@gmail.com>
Co-authored-by: Komal Yadav <komalyadav@microsoft.com>
Co-authored-by: Kayla Ames <kaseager@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

communication/azure-communication-identity - cspell found spelling errors in source code
3 participants