[Communication] - phone-numbers - Implement a phone number pool for update capabilities live tests #23116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
danielortega-msft
requested review from
scbedd,
benbp,
miguhern,
whisper6284,
lucasrsant,
RoyHerrod and
danielav7
as code owners
lucasrsant
reviewed
Feb 18, 2022
...ation/azure-communication-phonenumbers/test/test_phone_number_administration_client_async.py
Show resolved
Hide resolved
lucasrsant
approved these changes
Feb 18, 2022
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 4, 2022
…into new_metrics_advisor * 'main' of https://github.com/Azure/azure-sdk-for-python: (601 commits) pin markupsafe (Azure#23132) [Communication] - phone-numbers - Implement a phone number pool for update capabilities live tests (Azure#23116) Add timeout on Invoke-request call (Azure#23120) Sync eng/common directory with azure-sdk-tools for PR 2775 (Azure#23115) Update aggregate-report to use common credscan yml and update baseline file (Azure#23090) Update CHANGELOG.md (Azure#23119) [Issue helper] Update owner list (Azure#23079) [KV] Update changelogs for stable releases (Azure#23053) code and test (Azure#23047) [recoveryservicesbackup] fix multiple pages paging (Azure#23089) rerecord failing tests for fr (Azure#23107) [Test Proxy] Remove unnecessary git SHA fetch (Azure#23113) [Storage] Fix some mypy typing errors and typing imports (Azure#23098) Add logic to generate docs.ms ToC (Azure#23086) Fix broken link in tests.md (Azure#23110) Enable apistub gen step (Azure#23088) pin version of storage blob used for testing (Azure#23109) ensure that py36 can start the process properly (Azure#23108) fix cspell issues for azure-communication identity (Azure#22636) (Azure#23085) code and test (Azure#23077) ...
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
…pdate capabilities live tests (Azure#23116) * Use phone number pool in update capabilities tests * Fix env variable name in pipeline config file
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Mar 23, 2023
Adding support for child service configuration resource (Azure#23116) * Adds base for updating Microsoft.HybridConnectivity from version preview/2022-05-01-preview to version 2023-03-15 * Updates readme * Updates API version in new specs and examples * Adding support for child service configuration resource * Addressing PR comments * Handling camel casing * Updating the examples * Addresing issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a simple pool of available phone numbers to use in live test pipelines. This solves an issue with the update capabilities live tests caused when multiple tests attempt to modify the state of a phone number simultaneously.
In order to make use of this, the following environment variables need to be passed:
AZURE_TEST_AGENTspecifies the OS and runtime configuration for the job. It should contain the OS, the OS version and the framework/runtime version separated by underscores; e.g.windows_2019_python36.AZURE_PHONE_NUMBER_<AZURE_TEST_AGENT>, where<AZURE_TEST_AGENT>corresponds to the value of the variable described prior; e.g.AZURE_PHONE_NUMBER_windows_2019_python36.Additionally, by setting the
COMMUNICATION_SKIP_CAPABILITIES_LIVE_TESTvariable totrue, update capabilities tests can be skipped altoghether. This is useful because the amount of phone numbers available for testing (currently limited to 3) is smaller than the number of test jobs running in parallel.NOTE: If either the
AZURE_TEST_AGENTorAZURE_PHONE_NUMBER_<AZURE_TEST_AGENT>are not present when running live tests andCOMMUNICATION_SKIP_CAPABILITIES_LIVE_TEST=false, then the test run will fail. In any other scenario, theAZURE_PHONE_NUMBERwill be used.This PR is a follow-up to #22911.