Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR datalake-store/resource-manager/datalake-analytics/resource-manager] [ADLS] Adding vnet to read-only account properties and test examples for each API #2589

Merged
merged 8 commits into from
Jun 14, 2018

Conversation

AutorestCI
Copy link
Contributor

@AutorestCI
Copy link
Contributor Author

AutorestCI commented May 18, 2018

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-datalake-store

You can install the package azure-mgmt-datalake-store of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_3055#egg=azure-mgmt-datalake-store&subdirectory=azure-mgmt-datalake-store"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_3055#egg=azure-mgmt-datalake-store&subdirectory=azure-mgmt-datalake-store"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_3055
  • pip install -e ./azure-mgmt-datalake-store

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_3055
  • pip wheel --no-deps ./azure-mgmt-datalake-store

Package azure-mgmt-datalake-analytics

You can install the package azure-mgmt-datalake-analytics of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_3055#egg=azure-mgmt-datalake-analytics&subdirectory=azure-mgmt-datalake-analytics"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_3055#egg=azure-mgmt-datalake-analytics&subdirectory=azure-mgmt-datalake-analytics"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_3055
  • pip install -e ./azure-mgmt-datalake-analytics

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_3055
  • pip wheel --no-deps ./azure-mgmt-datalake-analytics

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented May 18, 2018

Codecov Report

Merging #2589 into master will increase coverage by 0.16%.
The diff coverage is 79.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2589      +/-   ##
==========================================
+ Coverage   55.85%   56.01%   +0.16%     
==========================================
  Files        7293     7365      +72     
  Lines      153449   154340     +891     
==========================================
+ Hits        85707    86459     +752     
- Misses      67742    67881     +139
Impacted Files Coverage Δ
...s/create_data_lake_store_account_parameters_py3.py 100% <100%> (ø)
...dels/create_or_update_compute_policy_parameters.py 100% <100%> (ø) ⬆️
...analytics/account/models/capability_information.py 100% <100%> (ø) ⬆️
...atalake-store/azure/mgmt/datalake/store/version.py 100% <100%> (ø) ⬆️
.../datalake/store/operations/locations_operations.py 100% <100%> (ø) ⬆️
...mgmt/datalake/analytics/account/models/resource.py 100% <100%> (ø) ⬆️
...add_data_lake_store_with_account_parameters_py3.py 100% <100%> (ø)
...s/create_compute_policy_with_account_parameters.py 100% <100%> (ø) ⬆️
...lake/analytics/account/models/operation_display.py 100% <100%> (ø) ⬆️
...atalake/analytics/account/operations/operations.py 100% <100%> (ø) ⬆️
... and 216 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad647ed...24b67e3. Read the comment docs.

@lmazuel
Copy link
Member

lmazuel commented Jun 13, 2018

@AutorestCI rebase

@AutorestCI
Copy link
Contributor Author

Rebase done and pushed to the branch

@lmazuel lmazuel requested a review from lewu-msft June 13, 2018 17:19
@lmazuel
Copy link
Member

lmazuel commented Jun 13, 2018

@lewu-msft please review the PR and write here your release plan (date, more Swagger to come, etc.). Thanks!

@lewu-msft
Copy link

@lmazuel Thanks! Currently there is no required release date for this change yet. I think this PR can be released once approved.
Swagger: Azure/azure-rest-api-specs@b66d57b
no more Swagger to come

@lewu-msft lewu-msft requested a review from lmazuel June 14, 2018 17:50
@lmazuel
Copy link
Member

lmazuel commented Jun 14, 2018

@AutorestCI rebase

@AutorestCI
Copy link
Contributor Author

Rebase done and pushed to the branch

@lmazuel lmazuel merged commit af49340 into master Jun 14, 2018
@lmazuel lmazuel deleted the restapi_auto_3055 branch June 14, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants