Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restapi auto 3055 [ADLS] adding test_vnet_operations #2733

Merged
merged 3 commits into from
Jun 13, 2018

Conversation

lewu-msft
Copy link

[ADLS] adding test_vnet_operations
ref: AutoPR

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@lewu-msft
Copy link
Author

@lmazuel Locally, when I ran `pytest azure-mgmt-datalake-store/tests/test_mgmt_datalake_store.py' It succeeded. I'm not sure why it failed after pushing. Any comment is appreciated

@lmazuel lmazuel changed the base branch from master to restapi_auto_3055 June 13, 2018 15:52
@lmazuel lmazuel force-pushed the restapi_auto_3055 branch from 2bd1e32 to ad24e58 Compare June 13, 2018 15:58
@codecov-io
Copy link

codecov-io commented Jun 13, 2018

Codecov Report

Merging #2733 into restapi_auto_3055 will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           restapi_auto_3055    #2733      +/-   ##
=====================================================
+ Coverage              56.07%   56.12%   +0.04%     
=====================================================
  Files                   7355     7355              
  Lines                 153780   153780              
=====================================================
+ Hits                   86233    86305      +72     
+ Misses                 67547    67475      -72
Impacted Files Coverage Δ
...t/datalake/store/operations/accounts_operations.py 82.74% <0%> (+0.44%) ⬆️
...mgmt/datalake/store/models/virtual_network_rule.py 100% <0%> (+28.57%) ⬆️
...reate_or_update_virtual_network_rule_parameters.py 100% <0%> (+28.57%) ⬆️
...e_or_update_virtual_network_rule_parameters_py3.py 100% <0%> (+28.57%) ⬆️
.../datalake/store/models/virtual_network_rule_py3.py 100% <0%> (+28.57%) ⬆️
...irtual_network_rule_with_account_parameters_py3.py 100% <0%> (+37.5%) ⬆️
...te_virtual_network_rule_with_account_parameters.py 100% <0%> (+37.5%) ⬆️
...ore/operations/virtual_network_rules_operations.py 62.28% <0%> (+42.98%) ⬆️
...e/azure/mgmt/datalake/store/models/sub_resource.py 100% <0%> (+44.44%) ⬆️
...ure/mgmt/datalake/store/models/sub_resource_py3.py 100% <0%> (+44.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745747c...023f170. Read the comment docs.

@lmazuel
Copy link
Member

lmazuel commented Jun 13, 2018

Hi @lewu-msft

First, thank you for the tests :)

I fixed your PR:

  • Base branch was incorrect, since you start from a branch, when you create the PR you need to define this branch as base.
  • You mixed up real credentials syntax and fake one. This will work on local machine, but not on Travis. See my last commit on your PR for details.

@lmazuel lmazuel merged commit e421441 into Azure:restapi_auto_3055 Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants