Adding CG support, moving analyze_deps to analyze job #4345

KarishmaGhiya · 2019-02-12T00:25:38Z

@Azure/azure-sdk-eng

# This is the 1st commit message: Resolved merge conflict by incorporating both suggestions # This is the commit message Azure#2: indentation fixed # This is the commit message Azure#3: indentation fixed # This is the commit message Azure#4: indentation fixed

adxsdk6 · 2019-02-12T00:25:39Z

Can one of the admins verify this patch?

adxsdk6 · 2019-02-12T00:25:39Z

Can one of the admins verify this patch?

codecov-io · 2019-02-12T00:48:39Z

Codecov Report

Merging #4345 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4345      +/-   ##
==========================================
+ Coverage   53.45%   53.53%   +0.07%     
==========================================
  Files       10449    10452       +3     
  Lines      218338   218687     +349     
==========================================
+ Hits       116717   117066     +349     
  Misses     101621   101621

Impacted Files	Coverage Δ
...osearch/azure/cognitiveservices/search/__init__.py	`100% <0%> (ø)`
azure-mgmt-documentdb/azure/mgmt/__init__.py	`100% <0%> (ø)`
...computervision/azure/cognitiveservices/__init__.py	`100% <0%> (ø)`
...rvicebus/azure/servicebus/control_client/models.py	`94.8% <0%> (+0.06%)`	⬆️
...ure/servicebus/control_client/servicebusservice.py	`93.07% <0%> (+0.11%)`	⬆️
...zure-sdk-tools/devtools_testutils/mgmt_testcase.py	`93.93% <0%> (+0.18%)`	⬆️
...e-keyvault/azure/keyvault/http_bearer_challenge.py	`89.28% <0%> (+0.19%)`	⬆️
...azure/servicemanagement/servicemanagementclient.py	`84.53% <0%> (+0.24%)`	⬆️
azure-keyvault/azure/keyvault/key_vault_client.py	`75% <0%> (+0.26%)`	⬆️
...rce/azure/mgmt/resource/features/feature_client.py	`93.33% <0%> (+0.31%)`	⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b307b4...2a77fb2. Read the comment docs.

scbedd

Glad to see the CG stuff works with python. Make these adjustments!

.azure-pipelines/client.yml

weshaggard · 2019-02-14T00:38:52Z

.azure-pipelines/client.yml

-        os.name: 'Linux'
-        os.vmImage: 'ubuntu-16.04'
-        python.version: '2.7'
+        OSName: 'Linux'


@scbedd it doesn't even look like we use the OSName anywhere so we should probably just delete it. @mikeharder I see you do use OsName as part of a task description in the JS pipeline. Given that the strategy name is used in the job name I personally don't feel it is worth plumbing this extra information through. What do others think?

Yeah. everywhere in the template we use os.name.

I must be missing the usages then as I don't see "os.name" or "OSName" being used anywhere in this pipeline.

You are correct. It's been updated.

…k-for-python into cgSupport

KarishmaGhiya added 4 commits February 4, 2019 14:27

Resolved merge conflicts

6b78a26

Resolved merge conflicts

be44c31

resolved conflict, updated job analyze with dependency steps

112b221

KarishmaGhiya requested a review from lmazuel as a code owner February 12, 2019 00:25

scbedd requested changes Feb 12, 2019

View reviewed changes

.azure-pipelines/client.yml Show resolved Hide resolved

.azure-pipelines/client.yml Outdated Show resolved Hide resolved

.azure-pipelines/client.yml Outdated Show resolved Hide resolved

mikeharder requested changes Feb 12, 2019

View reviewed changes

scbedd reviewed Feb 12, 2019

View reviewed changes

.azure-pipelines/client.yml Outdated Show resolved Hide resolved

KarishmaGhiya changed the title ~~resolved conflict, updated job analyze with dependency steps~~ Adding CG support, moving analyze_deps to analyze job Feb 12, 2019

Incorporating suggestions

4ee7074

KarishmaGhiya force-pushed the cgSupport branch from a0db1f9 to 4ee7074 Compare February 12, 2019 02:35

KarishmaGhiya added 2 commits February 11, 2019 20:06

single quote for variable

13c9a35

added publish step for Analyze Job

346516f

mikeharder requested changes Feb 12, 2019

View reviewed changes

.azure-pipelines/client.yml Outdated Show resolved Hide resolved

.azure-pipelines/client.yml Outdated Show resolved Hide resolved

.azure-pipelines/client.yml Show resolved Hide resolved

.azure-pipelines/client.yml Outdated Show resolved Hide resolved

scbedd reviewed Feb 12, 2019

View reviewed changes

.azure-pipelines/client.yml Outdated Show resolved Hide resolved

KarishmaGhiya added 7 commits February 12, 2019 15:25

Fixed the code that went wrong during merge

871b2d4

Fixing the mess from previous conflicts

98d224b

Fixed whitesapces and newlines

b2cb750

testing condition for public builds

d8d2e53

whitespaces, comments and CG condition

8c610a9

updated CG condition

f8a91a0

updated the condition CG

d2624cd

mikeharder approved these changes Feb 13, 2019

View reviewed changes

weshaggard reviewed Feb 13, 2019

View reviewed changes

.azure-pipelines/client.yml Outdated Show resolved Hide resolved

weshaggard reviewed Feb 13, 2019

View reviewed changes

.azure-pipelines/client.yml Outdated Show resolved Hide resolved

updates for standardization

6dde85a

weshaggard approved these changes Feb 13, 2019

View reviewed changes

Merge branch 'master' into cgSupport

2a77fb2

weshaggard reviewed Feb 14, 2019

View reviewed changes

scbedd approved these changes Feb 14, 2019

View reviewed changes

KarishmaGhiya added 2 commits February 13, 2019 17:23

cleanup

7c01710

Merge branch 'cgSupport' of https://github.com/KarishmaGhiya/azure-sd…

c959b85

…k-for-python into cgSupport

scbedd merged commit e5b7af7 into Azure:master Feb 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding CG support, moving analyze_deps to analyze job #4345

Adding CG support, moving analyze_deps to analyze job #4345

KarishmaGhiya commented Feb 12, 2019

adxsdk6 commented Feb 12, 2019

adxsdk6 commented Feb 12, 2019

codecov-io commented Feb 12, 2019 •

edited

Loading

scbedd left a comment

weshaggard Feb 14, 2019

scbedd Feb 14, 2019

weshaggard Feb 14, 2019

scbedd Feb 14, 2019

Adding CG support, moving analyze_deps to analyze job #4345

Adding CG support, moving analyze_deps to analyze job #4345

Conversation

KarishmaGhiya commented Feb 12, 2019

adxsdk6 commented Feb 12, 2019

adxsdk6 commented Feb 12, 2019

codecov-io commented Feb 12, 2019 • edited Loading

Codecov Report

scbedd left a comment

Choose a reason for hiding this comment

weshaggard Feb 14, 2019

Choose a reason for hiding this comment

scbedd Feb 14, 2019

Choose a reason for hiding this comment

weshaggard Feb 14, 2019

Choose a reason for hiding this comment

scbedd Feb 14, 2019

Choose a reason for hiding this comment

codecov-io commented Feb 12, 2019 •

edited

Loading