Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CG support, moving analyze_deps to analyze job #4345

Merged
merged 18 commits into from
Feb 14, 2019
Merged
Changes from 16 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 79 additions & 50 deletions .azure-pipelines/client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,28 +6,25 @@
trigger:
- master

variables:
PythonVersion: '3.6'

jobs:
- job: 'Build_Target_Packages'
- job: 'Build'

pool:
vmImage: 'ubuntu-16.04'
vmImage: 'ubuntu-16.04'

steps:
- task: UsePythonVersion@0
displayName: 'Use Python 3.6'
displayName: 'Use Python $(PythonVersion)'
inputs:
versionSpec: 3.6
versionSpec: $(PythonVersion)

- script: |
pip install wheel setuptools pathlib Jinja2 twine readme-renderer[md]
pip install wheel setuptools pathlib twine readme-renderer[md]
displayName: 'Prep Environment'

- task: PythonScript@0
displayName: 'Analyze dependencies'
inputs:
scriptPath: 'scripts/analyze_deps.py'
arguments: '--verbose --out "$(Build.SourcesDirectory)/dependencies.html"'

- task: PythonScript@0
displayName: 'Generate Packages'
inputs:
Expand All @@ -37,60 +34,90 @@ jobs:
- script: |
twine check $(Build.ArtifactStagingDirectory)/*
displayName: 'Verify Readme'
- task: PublishBuildArtifacts@1
displayName: 'Publish Artifacts'
KarishmaGhiya marked this conversation as resolved.
Show resolved Hide resolved
condition: succeededOrFailed()

- job: 'Analyze'

dependsOn:
- 'Build'

pool:
vmImage: 'ubuntu-16.04'

steps:
- task: UsePythonVersion@0
displayName: 'Use Python $(PythonVersion)'
inputs:
versionSpec: '$(PythonVersion)'

- task: CopyFiles@2
displayName: 'Move Dependencies Report to Build Artifacts'
- script: |
pip install wheel Jinja2
displayName: 'Prep Environment'

- task: PythonScript@0
displayName: 'Analyze dependencies'
enabled: true
inputs:
SourceFolder: '$(Build.SourcesDirectory)'
Contents: dependencies.html
TargetFolder: '$(Build.ArtifactStagingDirectory)'
condition: always()
scriptPath: 'scripts/analyze_deps.py'
arguments: '--verbose --out "$(Build.ArtifactStagingDirectory)/dependencies.html"'

- task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0
# ComponentGovernance is currently unable to run on pull requests of public projects. Running on non-PR
# builds should be sufficient.
condition: and(succeededOrFailed(), ne(variables['Build.Reason'],'PullRequest'))
displayName: 'Component Detection'

- task: PublishBuildArtifacts@1
mikeharder marked this conversation as resolved.
Show resolved Hide resolved
# To Publish artifacts generated by the 'Analyze dependencies' task under 'Analyze' job
displayName: 'Publish Artifacts'
condition: succeededOrFailed()

- job: 'Generic_Tests'

dependsOn:
- 'Build_Target_Packages'
- 'Build'

strategy:
matrix:
Linux_Python27:
os.name: 'Linux'
os.vmImage: 'ubuntu-16.04'
python.version: '2.7'
OSName: 'Linux'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scbedd it doesn't even look like we use the OSName anywhere so we should probably just delete it. @mikeharder I see you do use OsName as part of a task description in the JS pipeline. Given that the strategy name is used in the job name I personally don't feel it is worth plumbing this extra information through. What do others think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. everywhere in the template we use os.name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must be missing the usages then as I don't see "os.name" or "OSName" being used anywhere in this pipeline.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. It's been updated.

OSVmImage: 'ubuntu-16.04'
PythonVersion: '2.7'
Linux_Python34:
os.name: 'Linux'
os.vmImage: 'ubuntu-16.04'
python.version: '3.4'
OSName: 'Linux'
OSVmImage: 'ubuntu-16.04'
PythonVersion: '3.4'
Linux_Python35:
os.name: 'Linux'
os.vmImage: 'ubuntu-16.04'
python.version: '3.5'
OSName: 'Linux'
OSVmImage: 'ubuntu-16.04'
PythonVersion: '3.5'
Linux_Python36:
os.name: 'Linux'
os.vmImage: 'ubuntu-16.04'
python.version: '3.6'
OSName: 'Linux'
OSVmImage: 'ubuntu-16.04'
PythonVersion: '3.6'
Linux_Python37:
os.name: 'Linux'
os.vmImage: 'ubuntu-16.04'
python.version: '3.7'
OSName: 'Linux'
OSVmImage: 'ubuntu-16.04'
PythonVersion: '3.7'
Windows_Python35:
os.name: 'Windows'
os.vmImage: 'vs2017-win2016'
python.version: '3.5'
OSName: 'Windows'
OSVmImage: 'vs2017-win2016'
PythonVersion: '3.5'
MacOS_Python27:
os.name: 'MacOS'
os.vmImage: 'macOS-10.13'
python.version: '2.7'
OSName: 'MacOS'
OSVmImage: 'macOS-10.13'
PythonVersion: '2.7'

pool:
vmImage: '$(os.vmImage)'
vmImage: '$(OSVmImage)'

steps:
- task: UsePythonVersion@0
displayName: 'Use Python $(python.version)'
displayName: 'Use Python $(PythonVersion)'
inputs:
versionSpec: '$(python.version)'
versionSpec: '$(PythonVersion)'

- script: |
pip install pathlib twine codecov beautifulsoup4
Expand Down Expand Up @@ -125,12 +152,15 @@ jobs:
reportDirectory: '$(Build.SourcesDirectory)/htmlcov'

- job: Test_Alpha_Python

timeoutInMinutes: 90
condition: eq(variables['long_running_tests'], True)
dependsOn:
- 'Build_Target_Packages'
- 'Build'

pool:
vmImage: 'ubuntu-16.04'

steps:
- task: UsePythonVersion@0
displayName: 'Use Python 3.7 For Build Tools'
Expand All @@ -146,22 +176,23 @@ jobs:
cd debug
../configure --enable-optimizations --prefix=$HOME
make install

cd $(Build.SourcesDirectory)

PATH=/home/vsts/bin:$PATH
python3 -m ensurepip
python ./scripts/devops_tasks/setup_execute_tests.py -p python3 "$(build_targeting_string)"
displayName: 'Setup - Run Filtered Tests "Nightly" Python'
continueOnError: true

- job: Test_PyPy

timeoutInMinutes: 90
condition: eq(variables['long_running_tests'], True)
dependsOn:
- 'Build_Target_Packages'
- 'Build'

pool:
vmImage: 'ubuntu-16.04'

steps:
- task: UsePythonVersion@0
displayName: 'Use Python 3.7 For Build Tools'
Expand All @@ -175,10 +206,8 @@ jobs:
- script: |
cd ~/
wget https://bitbucket.org/pypy/pypy/downloads/pypy3-v6.0.0-linux64.tar.bz2
tar xf pypy3-v6.0.0-linux64.tar.bz2

cd $(Build.SourcesDirectory)

tar xf pypy3-v6.0.0-linux64.tar.bz2
cd $(Build.SourcesDirectory)
PATH=/home/vsts/pypy3-v6.0.0-linux64/bin/:$PATH
pypy3 -m ensurepip
python ./scripts/devops_tasks/setup_execute_tests.py -p pypy3 "$(build_targeting_string)"
Expand Down