Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine reset and evaluate in Check Enforcer. #629

Closed
mitchdenny opened this issue May 18, 2020 · 1 comment
Closed

Combine reset and evaluate in Check Enforcer. #629

mitchdenny opened this issue May 18, 2020 · 1 comment
Assignees
@mitchdenny
Labels
Check Enforcer EngSys This issue is impacting the engineering system.

Comments

@mitchdenny
Copy link
Contributor

Check Enforcer currently requires stuck PRs to use both a reset and evaluate command. These should be combined into one.

Also consider implementing the check actions commands to make knowing the commands unnecessary.
@weshaggard weshaggard added the EngSys This issue is impacting the engineering system. label May 19, 2020
@mitchdenny mitchdenny mentioned this issue Jun 1, 2020
Merged
@mitchdenny
Copy link
Contributor Author

This issue includes the idea of adding an option to add an action button to the Check Run. However the property does not appear to be exposed in the Check Run event payload. I've filed an issue about it here:

octokit/octokit.net#2195

I'm not enthused about parsing the JSON payload manually. I have PR open that combines the reset and evaluate options which is what the initial request was but I'll leave this open for a little while to see what the response to my question about Octokit is.

sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this issue Dec 3, 2020
@vhvb1989 @ahsonkhan
Remove accessing to _internal fields in curl transport adapter (Azure…
6d1f4c6 
…#629)

* Allow empty header

* test for supporting empty headers

* adding docs

* enhance docs

* fix documentation for code

* fix docs for function

* remove internal access from transport to response

* adding docs for functions

* rename function to be public

* Apply suggestions from code review

Co-Authored-By: Ahson Khan <ahson_ahmedk@yahoo.com>

* create getters for http request parts

* Apply suggestions from code review

Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>

* do not add 0 at the end of responses

* fix precondition name changed

* Apply suggestions from code review

Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>

Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitchdenny mitchdenny

Labels
Check Enforcer EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mitchdenny @weshaggard @kurtzeborn