Combine Check Enforcer reset and evaluate #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdenny
added
EngSys
JimSuplizio
approved these changes
Jun 1, 2020
Yeah ... we'll need to watch this one pretty closely. One of the reasons I didn't massively refactor the code to remove some of the duplication (easier to snap back). |
|
/check-enforcer reset |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #629. Basically people who are using the Check Enforcer
/check-enforcer resetcommand don't know to do anevaluateafterwards. This change makes both commands do the same thing.I'll be removing references in our documentation around
resetsinceevaluateis probably the way we want people to think about it moving forward.