Consume DevOps Logging #1039
Merged
Consume DevOps Logging #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
reviewed
Sep 26, 2020
eng/scripts/Verify-And-Merge-PRs.ps1
Outdated
| @@ -5,25 +5,7 @@ param( | |||
| [switch]$devOpsLogging = $false | |||
There was a problem hiding this comment.
I think we can eliminate this parameter as well now.
weshaggard
approved these changes
Sep 26, 2020
chidozieononiwu
force-pushed
the
UseDevOpsLogging
branch
from
23b98ca to
6ba524c
Compare
mitchdenny
approved these changes
Sep 27, 2020
mitchdenny
reviewed
Sep 27, 2020
| Write-Error "$args" | ||
| } | ||
| } | ||
| . "${PSScriptRoot}..\common\scripts\logging.ps1" |
There was a problem hiding this comment.
nit: PowerShell conventions would make this Logging.ps1
There was a problem hiding this comment.
Renaming in git where the only change is a case change ends up causing more troubles than benefit. I'll just leave this.
There was a problem hiding this comment.
Yes we can potentially clean some of this up with #829.
mitchdenny
approved these changes
Sep 27, 2020
|
/check-enforcer override |
benbp
pushed a commit
that referenced
this pull request
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consume DevOps Logging from eng\common\scripts\logging.ps1