Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume DevOps Logging #1039

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Consume DevOps Logging #1039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 2 additions & 21 deletions eng/scripts/Verify-And-Merge-PRs.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,10 @@
param(
$PRDataArtifactPath,
$AuthToken,
$ShouldMerge,
[switch]$devOpsLogging = $false
$ShouldMerge
)

function LogWarning
{
if ($devOpsLogging) {
Write-Host "##vso[task.LogIssue type=warning;]$args"
}
else {
Write-Warning "$args"
}
}

function LogError
{
if ($devOpsLogging) {
Write-Host "##vso[task.logissue type=error]$args"
}
else {
Write-Error "$args"
}
}
. "${PSScriptRoot}..\common\scripts\logging.ps1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: PowerShell conventions would make this Logging.ps1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming in git where the only change is a case change ends up causing more troubles than benefit. I'll just leave this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can potentially clean some of this up with #829.


$ReadyForMerge = $true
$mergablePRs = @()
Expand Down