-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make docs.ms link relative link #3221
Conversation
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get an example of this running and updating links? I think this can be accomplished by setting SetDevVersion
to true
and queuing a build for a service pipeline.
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
The test is in description. |
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think one small corner case still exists here: someone uses a language region-language code is used here that isn't en-us
... We could try to match against a list of possible codes but I don't think the effort needed to generate and maintain such a list would be worth it in the scope of this effort.
Searching through the Java codebase reveals that other language codes are not in use in our README.md files.
Furthermore those errors would be flagged as warnings in OPS and could be addressed on a case by case basis if we start seeing more pop up.
I thought about the other languages as well but based on our link guidance folks shouldn't even have the |
@@ -129,13 +129,12 @@ author: $author | |||
ms.author: $msauthor | |||
ms.date: $date | |||
ms.topic: reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were these removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is according the their metadata guidance. If we use the ms.service, then the set of ms.prod
and ms.technology
are not necessary.
https://review.docs.microsoft.com/en-us/help/contribute/metadata-attributes?branch=main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many OPS warning regarding we are using wrong ms.prod value
I think we should leave the other locale as it is, so people can redirect to the right language as they defined. |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
https://raw.githubusercontent.com/Azure/azure-docs-sdk-java/main/docs-ref-services/preview/sdk-template-readme.md
Metadata definition: https://review.docs.microsoft.com/en-us/help/contribute/metadata-attributes?branch=main