Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docs.ms link relative link #3221

Merged
3 commits merged into from
Apr 27, 2022
Merged

Make docs.ms link relative link #3221

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca22ba9
Make docs.ms link relative link
sima-zhu Apr 26, 2022
0c68288
Update Update-DocsMsMetadata.ps1
sima-zhu Apr 26, 2022
afe1eba
Update eng/common/scripts/Update-DocsMsMetadata.ps1
sima-zhu Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions eng/common/scripts/Update-DocsMsMetadata.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,12 @@ author: $author
ms.author: $msauthor
ms.date: $date
ms.topic: reference
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these removed?

Copy link
Contributor Author

@sima-zhu sima-zhu Apr 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is according the their metadata guidance. If we use the ms.service, then the set of ms.prod and ms.technology are not necessary.
https://review.docs.microsoft.com/en-us/help/contribute/metadata-attributes?branch=main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many OPS warning regarding we are using wrong ms.prod value

ms.prod: azure
ms.technology: azure
ms.devlang: $Language
ms.service: $service
---
"@

$ReadmeContent = $ReadmeContent -replace "https://docs.microsoft.com(/en-us)?/?", "/"
return "$header`n$ReadmeContent"
}

Expand Down