Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release lease on shutdown #4226

Closed
matthchr opened this issue Aug 28, 2024 · 2 comments · Fixed by #4250
Closed

Release lease on shutdown #4226

matthchr opened this issue Aug 28, 2024 · 2 comments · Fixed by #4250
Assignees
@matthchr
Milestone
v2.10.0

Comments

@matthchr
Copy link
Member

Makes restarts cheaper.
@matthchr matthchr added this to the v2.10.0 milestone Aug 28, 2024
@matthchr matthchr self-assigned this Aug 28, 2024
@matthchr
Copy link
Member Author

It looks like controller-runtime already does this for us automatically (see kubernetes-sigs/controller-runtime#967), but we should confirm that:

  1. It actually is working for us.
  2. That we're doing the right thing(s) in the controllers so that we don't block graceful shutdown.

@matthchr
Copy link
Member Author

matthchr commented Sep 5, 2024

I looked into this more, we need to set the LeaderElectionReleaseOnCancel setting.

matthchr added a commit to matthchr/azure-service-operator that referenced this issue Sep 6, 2024
@matthchr
Release lease when the pod is terminated
df5e0e2 
Closes Azure#4226.
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Sep 6, 2024
@matthchr
Release lease when the pod is terminated
ba715c7 
Closes Azure#4226.
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Sep 6, 2024
@matthchr
Release lease when the pod is terminated
45acf9a 
Closes Azure#4226.
@matthchr matthchr mentioned this issue Sep 6, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 9, 2024
@matthchr
Release lease when the pod is terminated (#4250)
0e346df 
Closes #4226.
@github-project-automation github-project-automation bot moved this from Backlog to Recently Completed in Azure Service Operator Roadmap Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthchr matthchr

Labels
None yet
Projects
Azure Service Operator Roadmap
Archived in project
Milestone
v2.10.0
Development

Successfully merging a pull request may close this issue.

Release lease when the pod is terminated matthchr/azure-service-operator
1 participant
@matthchr