Release lease when the pod is terminated

Closes Azure#4226.
matthchr · Sep 6, 2024 · ba715c7 · ba715c7
1 parent b373ec4
commit ba715c7
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/v2/cmd/controller/app/setup.go b/v2/cmd/controller/app/setup.go
@@ -76,12 +76,16 @@ func SetupControllerManager(ctx context.Context, setupLog logr.Logger, flgs *Fla
 
 	k8sConfig := ctrl.GetConfigOrDie()
 	mgr, err := ctrl.NewManager(k8sConfig, ctrl.Options{
-		Scheme:                 scheme,
-		NewCache:               cacheFunc,
-		LeaderElection:         flgs.EnableLeaderElection,
-		LeaderElectionID:       "controllers-leader-election-azinfra-generated",
-		HealthProbeBindAddress: flgs.HealthAddr,
-		Metrics:                getMetricsOpts(flgs),
+		Scheme:           scheme,
+		NewCache:         cacheFunc,
+		LeaderElection:   flgs.EnableLeaderElection,
+		LeaderElectionID: "controllers-leader-election-azinfra-generated",
+		// It's only safe to set LeaderElectionReleaseOnCancel to true if the manager binary ends
+		// when the manager exits. This is the case with us today, so we set this to true to
+		// enable faster lease transfers.
+		LeaderElectionReleaseOnCancel: true,
+		HealthProbeBindAddress:        flgs.HealthAddr,
+		Metrics:                       getMetricsOpts(flgs),
 		WebhookServer: webhook.NewServer(webhook.Options{
 			Port:    flgs.WebhookPort,
 			CertDir: flgs.WebhookCertDir,