-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AVM Module Issue]: Setting up 'AvailabilityZones' is not supported in Sku :'Developer' #2561
Comments
@dewolfs, thanks for submitting this issue for the Important A member of the @Azure/avm-res-apimanagement-service-module-owners-bicep or @Azure/avm-res-apimanagement-service-module-contributors-bicep team will review it soon! |
I'm having the same problem, var subnetResourceId = resourceId(networkResourceGroup,'Microsoft.Network/virtualNetworks/subnets', vnetName, subnetName) // resource apimService 'Microsoft.ApiManagement/service@2021-01-01-preview' = { |
Sorry for that, folks--definitely a bug. I am almost done with a fix and will be making a PR shortly. |
## Description <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes #123 Fixes #456 Closes #123 Closes #456 --> Closes #2561 - Added tests for different SKUs to ensure no more issues in the future - Disable some APIM PSRule tests that are $$ and not necessary for non-prod deployments - fix logic to ensure various SKUs can be deployed and use availability zones and scale units ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [![avm.res.api-management.service](https://github.com/tony-box/bicep-registry-modules/actions/workflows/avm.res.api-management.service.yml/badge.svg?branch=fix%2F2561)](https://github.com/tony-box/bicep-registry-modules/actions/workflows/avm.res.api-management.service.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [x] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [x] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Tony Box <tobox@microsoft.com>
Hi! Thanks for the fix! I see that it is still a problem in the latest available version 0.2.1. Any ETA when a new version will be released with this fix? |
@IngerMathilde this worked for me, I think the key was setting the zones and additional locations to [] explicitly. Hope this helps you
|
@dhayes-ccl @IngerMathilde interesting... the test deployment for a Developer SKU deploys successfully using only the required params:
I'm not sure why explicitly setting the |
@dhayes-ccl @IngerMathilde sorry--I just realized you two are using Regardless, I am testing out using empty arrays instead of null arrays to see if that removes any issues if you explicitly set the |
@dhayes-ccl thanks this helped. Had zones and additionalLocations set to null and not empty arrays. @tony-box I am quite new to using azure verified modules, but If I look at the tag associated with the last release (https://github.com/Azure/bicep-registry-modules/blob/avm/res/api-management/service/0.2.1/avm/res/api-management/service/main.bicep), it is not up to date with main. That is why I was wondering if we needed a 0.2.2 version. |
@IngerMathilde @dewolfs PR raised to fix the issue. deployment was successful when I set the |
Check for previous/existing GitHub issues
Issue Type?
Feature Request
Module Name
avm/res/api-management/service
(Optional) Module Version
0.2.0
Description
Hi,
I want to deploy an APIM instance in the SKU "Developer". The Developer SKU defaults to 1 instance count.
When the following bicep code is used:
i get the error:
If I look at the module, the SKU parameter will always be 2 if I choose Developer. But technically that's not possible ?!
bicep-registry-modules/avm/res/api-management/service/main.bicep
Line 85 in c58ce67
bicep-registry-modules/avm/res/api-management/service/main.bicep
Line 224 in c58ce67
How to proceed to deploy APIM with the Developer SKU ?
(Optional) Correlation Id
No response
The text was updated successfully, but these errors were encountered: