-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: APIM SKUs not deploying due to incorrect param logic #2565
Conversation
updated to upstream
avm/res/api-management/service/tests/e2e/defaults.consumptionSku/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/api-management/service/tests/e2e/defaults.developerSku/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/api-management/service/tests/e2e/defaults.consumptionSku/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/api-management/service/tests/e2e/defaults.v2Sku/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/api-management/service/tests/e2e/developerSku/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/api-management/service/tests/e2e/defaults/main.test.bicep
Outdated
Show resolved
Hide resolved
Sorry @tony-box for the long review time as I was OOF a few days. These above are my last comments before approval. Great job on this one! |
Any updates on when this will be merged into main? |
Hey @tony-box, any update on this one? Please just let me know if the latest comments make sense 🙂 |
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@dhayes-ccl @eriqua sorry for the delay. I made some logic changes to address #2565 (comment) with default settings for managed identities. The automated test deployments are currently running--once they are all green, I will request re-approval. |
avm/res/api-management/service/tests/e2e/defaults/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/api-management/service/tests/e2e/waf-aligned/main.test.bicep
Outdated
Show resolved
Hide resolved
Thanks for this fix! All looks good to me! |
Description
Closes #2561
Closes #2617
dependsOn
serivice_namedValues within service_loggers to allow for a namedValue credential to be passed to loggers within same pipeline runPipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.