Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APIM SKUs not deploying due to incorrect param logic #2565

Merged
merged 27 commits into from
Jul 24, 2024

Conversation

tony-box
Copy link
Contributor

@tony-box tony-box commented Jun 28, 2024

Description

Closes #2561
Closes #2617

  • Added tests for different SKUs to ensure no more issues in the future
  • Disable some APIM PSRule tests that are $$ and not necessary for non-prod deployments
  • fix logic to ensure various SKUs can be deployed and use availability zones and scale units
  • add dependsOn serivice_namedValues within service_loggers to allow for a namedValue credential to be passed to loggers within same pipeline run

Pipeline Reference

Pipeline
avm.res.api-management.service

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jun 28, 2024
@tony-box tony-box marked this pull request as ready for review June 28, 2024 02:08
@tony-box tony-box requested review from a team as code owners June 28, 2024 02:08
@tony-box tony-box enabled auto-merge (squash) June 28, 2024 02:09
@tony-box tony-box added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Jun 28, 2024
@eriqua eriqua added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Jun 29, 2024
@tony-box tony-box requested a review from eriqua July 3, 2024 04:31
@tony-box tony-box requested a review from jtracey93 July 4, 2024 17:45
@eriqua
Copy link
Contributor

eriqua commented Jul 8, 2024

Sorry @tony-box for the long review time as I was OOF a few days. These above are my last comments before approval. Great job on this one!

@dhayes-ccl
Copy link

Any updates on when this will be merged into main?

@eriqua
Copy link
Contributor

eriqua commented Jul 20, 2024

Hey @tony-box, any update on this one? Please just let me know if the latest comments make sense 🙂
Also unfortunately some merge conflicts happened. Would you please be able to resolve them?

tony-box and others added 2 commits July 22, 2024 10:11
@tony-box tony-box requested a review from a team as a code owner July 22, 2024 16:46
@tony-box
Copy link
Contributor Author

@dhayes-ccl @eriqua sorry for the delay. I made some logic changes to address #2565 (comment) with default settings for managed identities. The automated test deployments are currently running--once they are all green, I will request re-approval.

@tony-box tony-box requested a review from eriqua July 23, 2024 15:42
@tony-box tony-box merged commit d25ccbc into Azure:main Jul 24, 2024
4 checks passed
@dhayes-ccl
Copy link

Thanks for this fix! All looks good to me!

@tony-box tony-box deleted the fix/2561 branch July 31, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
5 participants