Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added support for user mi avm/res/search/search-service #2200

Merged
merged 10 commits into from
Jun 27, 2024

Conversation

rajeshkaremane
Copy link
Contributor

@rajeshkaremane rajeshkaremane commented Jun 5, 2024

Description

Added support for User Managed Identity

Fixes #2199

Pipeline Reference

avm.res.search.search-service (using a temporary branch)

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jun 5, 2024
@rajeshkaremane rajeshkaremane marked this pull request as ready for review June 5, 2024 16:32
@rajeshkaremane rajeshkaremane requested review from a team as code owners June 5, 2024 16:32
@rajeshkaremane rajeshkaremane changed the title added support for user mi fix: added support for user mi Jun 5, 2024
@eriqua eriqua added Needs: Module Owner 📣 This module needs an owner to develop or maintain it Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Jun 6, 2024
@eriqua eriqua changed the title fix: added support for user mi fix: added support for user mi avm/res/search/search-service Jun 6, 2024
@matebarabas
Copy link
Contributor

@krbar, as the owner of this module, please take a look. Thanks!

Copy link
Contributor

@krbar krbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajeshkaremane Thank you very much for your contribution! Could you by any chance attach a pipeline badge showing that the module passes all validations?

@rajeshkaremane
Copy link
Contributor Author

@rajeshkaremane Thank you very much for your contribution! Could you by any chance attach a pipeline badge showing that the module passes all validations?

Hi,
I have deployed using an internal pipeline
https://dev.azure.com/defragovuk/DEFRA-FFC/_apis/build/status%2FADP%2FCore%2Fplatform-adp-core-env?repoName=DEFRA%2Fadp-infrastructure-core&branchName=rv%2F382090-openaiinfra

@krbar
Copy link
Contributor

krbar commented Jun 26, 2024

@rajeshkaremane
Thank you, I tested the module and it required a few minor updates:

Now the module looks fine and passes all tests,
@Azure/avm-core-team-technical-bicep please review the changes as I added some new code to the PR and cannot approve it any more. The changes have been tested in a (temporary) branch users/krbr/pr2200test which I will delete after merging this PR.

Here is a pipeline badge: avm.res.search.search-service (the final test still runs)

@krbar krbar marked this pull request as draft June 26, 2024 13:13
@rajeshkaremane rajeshkaremane marked this pull request as ready for review June 26, 2024 13:18
@rajeshkaremane rajeshkaremane marked this pull request as draft June 26, 2024 13:20
@rajeshkaremane
Copy link
Contributor Author

Thanks @krbar. Looks like the pipeline has failed due to existing resource with same name . Could you please delete the resource and rerun thanks

@rajeshkaremane rajeshkaremane marked this pull request as ready for review June 27, 2024 08:48
@rajeshkaremane
Copy link
Contributor Author

Looks good to me. You should now be able to approve the PR

@krbar
Copy link
Contributor

krbar commented Jun 27, 2024

Looks good to me. You should now be able to approve the PR

Waiting for a green pipeline validation, test is still running: avm.res.search.search-service

avm/res/search/search-service/main.bicep Outdated Show resolved Hide resolved
@krbar krbar merged commit 264dc42 into Azure:main Jun 27, 2024
4 checks passed
@rajeshkaremane
Copy link
Contributor Author

Hi, @krbar Where can I see the version tags being applied?

@AlexanderSehr
Copy link
Contributor

Hey @rajeshkaremane the most straightforward way I know of is directly in the pipeline log: https://github.com/Azure/bicep-registry-modules/actions/runs/9694279814/job/26753261544#step:4:291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Search Service - Does not support User MI
5 participants