-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adjusted telemetry 'deployments' suppression (letters M-Z) #2350
Merged
AlexanderSehr
merged 192 commits into
Azure:main
from
AlexanderSehr:users/alsehr/telemetryModuleTest_attempt2
Jun 19, 2024
Merged
feat: Adjusted telemetry 'deployments' suppression (letters M-Z) #2350
AlexanderSehr
merged 192 commits into
Azure:main
from
AlexanderSehr:users/alsehr/telemetryModuleTest_attempt2
Jun 19, 2024
+1,798
−1,743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts.ps1 Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…ts.ps1 Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
AlexanderSehr
changed the title
feat: Adjusted telemetry 'deployments' suppression
feat: Adjusted telemetry 'deployments' suppression (letters M-Z)
Jun 14, 2024
8 tasks
krbar
previously approved these changes
Jun 14, 2024
oZakari
previously approved these changes
Jun 15, 2024
maldineh
reviewed
Jun 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed
arnoldna
previously approved these changes
Jun 17, 2024
AlexanderSehr
dismissed stale reviews from oZakari, krbar, and arnoldna
via
June 18, 2024 18:43
d7e1d12
ChrisSidebotham
approved these changes
Jun 19, 2024
hundredacres
pushed a commit
to hundredacres/bicep-registry-modules
that referenced
this pull request
Jun 19, 2024
…re#2350) ## Description > This PR covers all modules starting with the letters M-Z - Added deployments suppression to module instead of just bicepconfig to also apply to anybody using our modules without a likewise configure bicepconfig locally - Updated used deployment RP API version - Formatted all templates - Regenerated all templates & readmes (due to API update) > New attempt after Azure#1480 ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [![avm.res.analysis-services.server](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.analysis-services.server.yml/badge.svg?branch=users%2Falsehr%2FtelemetryModuleTest_attempt2&event=workflow_dispatch)](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.analysis-services.server.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation --------- Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com> Co-authored-by: Maher Aldineh <maldineh@yahoo.com> Co-authored-by: ChrisSidebotham-MSFT <48600046+ChrisSidebotham@users.noreply.github.com>
11 tasks
AlexanderSehr
added a commit
that referenced
this pull request
Jul 5, 2024
#2356) ## Description This PR should only be merged after - #2350 - #2353 - #2354 - #2355 - #2498 ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [x] Update to CI Environment or utilities (Non-module affecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation --------- Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Class: Resource Module 📦
This is a resource module
Needs: Core Team 🧞
This item needs the AVM Core Team to review it
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
Type: CI 🚀
This issue is related to the AVM CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.