Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adjusted telemetry 'deployments' suppression (letters M-Z) #2350

Merged

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jun 13, 2024

Description

This PR covers all modules starting with the letters M-Z

  • Added deployments suppression to module instead of just bicepconfig to also apply to anybody using our modules without a likewise configure bicepconfig locally
  • Updated used deployment RP API version
  • Formatted all templates
  • Regenerated all templates & readmes (due to API update)

New attempt after #1480

Pipeline Reference

Pipeline
avm.res.analysis-services.server

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr changed the title feat: Adjusted telemetry 'deployments' suppression feat: Adjusted telemetry 'deployments' suppression (letters M-Z) Jun 14, 2024
krbar
krbar previously approved these changes Jun 14, 2024
oZakari
oZakari previously approved these changes Jun 15, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review June 15, 2024 10:09
Copy link
Contributor

@maldineh maldineh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

arnoldna
arnoldna previously approved these changes Jun 17, 2024
@AlexanderSehr AlexanderSehr dismissed stale reviews from oZakari, krbar, and arnoldna via d7e1d12 June 18, 2024 18:43
@AlexanderSehr AlexanderSehr merged commit 9995802 into Azure:main Jun 19, 2024
8 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/telemetryModuleTest_attempt2 branch June 19, 2024 13:21
hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this pull request Jun 19, 2024
…re#2350)

## Description

> This PR covers all modules starting with the letters M-Z

- Added deployments suppression to module instead of just bicepconfig to
also apply to anybody using our modules without a likewise configure
bicepconfig locally
- Updated used deployment RP API version
- Formatted all templates
- Regenerated all templates & readmes (due to API update)

> New attempt after Azure#1480

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.analysis-services.server](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.analysis-services.server.yml/badge.svg?branch=users%2Falsehr%2FtelemetryModuleTest_attempt2&event=workflow_dispatch)](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.analysis-services.server.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

---------

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Maher Aldineh <maldineh@yahoo.com>
Co-authored-by: ChrisSidebotham-MSFT <48600046+ChrisSidebotham@users.noreply.github.com>
AlexanderSehr added a commit that referenced this pull request Jul 5, 2024
#2356)

## Description

This PR should only be merged after
- #2350
- #2353 
- #2354 
- #2355 
- #2498 

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [x] Update to CI Environment or utilities (Non-module affecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

---------

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: CI 🚀 This issue is related to the AVM CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants