Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bicep MSBuild target does not correctly support incremental builds #5253

Closed
stan-sz opened this issue Nov 24, 2021 · 1 comment · Fixed by #5254
Closed

Bicep MSBuild target does not correctly support incremental builds #5253

stan-sz opened this issue Nov 24, 2021 · 1 comment · Fixed by #5254

Comments

@stan-sz
Copy link
Contributor

stan-sz commented Nov 24, 2021

Bicep version
v0.4.1008

Describe the bug
According to https://docs.microsoft.com/en-us/visualstudio/msbuild/how-to-build-incrementally?view=vs-2022 the Bicep target does not declare inputs and outputs to take the full advantage of MSBuild incrementalism.

To Reproduce
Build the same MSBuild project twice, that calls the Bicep target.

Expected: on the second run the bicep files are not processed
Actual: bicep is called on each build

@ghost ghost added the Needs: Triage 🔍 label Nov 24, 2021
stan-sz added a commit to stan-sz/bicep that referenced this issue Nov 24, 2021
@stan-sz stan-sz mentioned this issue Nov 24, 2021
14 tasks
@majastrz
Copy link
Member

majastrz commented Dec 1, 2021

Yeah, I didn't include it in the original nuget packages.

shenglol pushed a commit that referenced this issue Mar 17, 2022
* Bicep nuget packages fixes

Fixes #5253
Fixes #5238
Fixes #5236

* Mitigate lack of multitarget support

microsoft/MSBuildSdks#155

* Revert "Mitigate lack of multitarget support"

This reverts commit 9dcad82.

* Revert "Bicep nuget packages fixes"

This reverts commit be85aff.

* Add support for arrays in (last)indexOf

Closes #4895

* UTs and baseline changes

Upgraded Azure.Deployments.* package dependencies to 1.0.546

* Fix test case

* Update description.
StephenWeatherford pushed a commit that referenced this issue Mar 23, 2022
* Bicep nuget packages fixes

Fixes #5253
Fixes #5238
Fixes #5236

* Mitigate lack of multitarget support

microsoft/MSBuildSdks#155

* Revert "Mitigate lack of multitarget support"

This reverts commit 9dcad82.

* Revert "Bicep nuget packages fixes"

This reverts commit be85aff.

* Cleanup all unused using statements
SimonWahlin pushed a commit to SimonWahlin/bicep that referenced this issue Mar 30, 2022
* Bicep nuget packages fixes

Fixes Azure#5253
Fixes Azure#5238
Fixes Azure#5236

* Mitigate lack of multitarget support

microsoft/MSBuildSdks#155

* Revert "Mitigate lack of multitarget support"

This reverts commit 9dcad82.

* Revert "Bicep nuget packages fixes"

This reverts commit be85aff.

* Add support for arrays in (last)indexOf

Closes Azure#4895

* UTs and baseline changes

Upgraded Azure.Deployments.* package dependencies to 1.0.546

* Fix test case

* Update description.
SimonWahlin pushed a commit to SimonWahlin/bicep that referenced this issue Mar 30, 2022
* Bicep nuget packages fixes

Fixes Azure#5253
Fixes Azure#5238
Fixes Azure#5236

* Mitigate lack of multitarget support

microsoft/MSBuildSdks#155

* Revert "Mitigate lack of multitarget support"

This reverts commit 9dcad82.

* Revert "Bicep nuget packages fixes"

This reverts commit be85aff.

* Cleanup all unused using statements
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants