-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support array in (last)indexOf function #5627
Conversation
Fixes Azure#5253 Fixes Azure#5238 Fixes Azure#5236
This reverts commit 9dcad82.
This reverts commit be85aff.
Upgraded Azure.Deployments.* package dependencies to 1.0.546
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look great! I'm just putting a block on this PR as we need to wait for the ARM release train to complete to all regions and national clouds before merging.
FYI, this is present in ARM builds 2021w51 and later. Once this has been deployed to all clouds, we can merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new functions are deployed everywhere.
* Bicep nuget packages fixes Fixes Azure#5253 Fixes Azure#5238 Fixes Azure#5236 * Mitigate lack of multitarget support microsoft/MSBuildSdks#155 * Revert "Mitigate lack of multitarget support" This reverts commit 9dcad82. * Revert "Bicep nuget packages fixes" This reverts commit be85aff. * Add support for arrays in (last)indexOf Closes Azure#4895 * UTs and baseline changes Upgraded Azure.Deployments.* package dependencies to 1.0.546 * Fix test case * Update description.
Fixes #4895
Contributing a Pull Request
If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.
Contributing to documentation
Contributing an example
We are integrating the Bicep examples into the Azure QuickStart Templates. If you'd like to contribute new example
.bicep
files that showcase abilities of the language, please follow these instructions to add them directly there. We can still take bug reports and fixes for the existing examples for the time being.dotnet test
Contributing a feature
Contributing a snippet
I have a snippet that is either a single, generic resource or multi resource that uses parent-child syntax
I have checked that there is not an equivalent snippet already submitted
I have used camelCasing unless I have a justification to use another casing style
I have placeholders values that correspond to their property names (e.g.
dnsPrefix: 'dnsPrefix'
), unless it's a property that MUST be changed or parameterized in order to deploy. In that case, I use 'REQUIRED' e.g. keyDataI have my symbolic name as the first tab stop ($1) in the snippet. e.g. res-aks-cluster.bicep
I have a resource name property equal to "name"
e.g.