Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array in (last)indexOf function #5627

Merged
merged 16 commits into from
Mar 17, 2022
Merged

Support array in (last)indexOf function #5627

merged 16 commits into from
Mar 17, 2022

Conversation

stan-sz
Copy link
Contributor

@stan-sz stan-sz commented Jan 13, 2022

Fixes #4895

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

Contributing to documentation

Contributing an example

We are integrating the Bicep examples into the Azure QuickStart Templates. If you'd like to contribute new example .bicep files that showcase abilities of the language, please follow these instructions to add them directly there. We can still take bug reports and fixes for the existing examples for the time being.

  • This is a bug fix for an existing example
  • I have resolved all warnings and errors shown by the Bicep VS Code extension
  • I have checked that all tests are passing by running dotnet test
  • I have consistent casing for all of my identifiers and am using camelCasing unless I have a justification to use another casing style

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

Contributing a snippet

  • I have a snippet that is either a single, generic resource or multi resource that uses parent-child syntax

  • I have checked that there is not an equivalent snippet already submitted

  • I have used camelCasing unless I have a justification to use another casing style

  • I have placeholders values that correspond to their property names (e.g. dnsPrefix: 'dnsPrefix'), unless it's a property that MUST be changed or parameterized in order to deploy. In that case, I use 'REQUIRED' e.g. keyData

  • I have my symbolic name as the first tab stop ($1) in the snippet. e.g. res-aks-cluster.bicep

  • I have a resource name property equal to "name"

    e.g.

    resource aksCluster 'Microsoft.ContainerService/managedClusters@2021-03-01' = {
      name: 'name'

@stan-sz stan-sz changed the title Patch 5 Support array in (last)indexOf function Jan 13, 2022
Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great! I'm just putting a block on this PR as we need to wait for the ARM release train to complete to all regions and national clouds before merging.

@stan-sz
Copy link
Contributor Author

stan-sz commented Jan 14, 2022

The reported failure is a flaky test, can you confirm?

image

@anthony-c-martin
Copy link
Member

FYI, this is present in ARM builds 2021w51 and later. Once this has been deployed to all clouds, we can merge this PR.

Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shenglol shenglol dismissed anthony-c-martin’s stale review March 17, 2022 17:24

The new functions are deployed everywhere.

@shenglol shenglol merged commit 9fe1438 into Azure:main Mar 17, 2022
SimonWahlin pushed a commit to SimonWahlin/bicep that referenced this pull request Mar 30, 2022
* Bicep nuget packages fixes

Fixes Azure#5253
Fixes Azure#5238
Fixes Azure#5236

* Mitigate lack of multitarget support

microsoft/MSBuildSdks#155

* Revert "Mitigate lack of multitarget support"

This reverts commit 9dcad82.

* Revert "Bicep nuget packages fixes"

This reverts commit be85aff.

* Add support for arrays in (last)indexOf

Closes Azure#4895

* UTs and baseline changes

Upgraded Azure.Deployments.* package dependencies to 1.0.546

* Fix test case

* Update description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let lastIndexOf operate on arrays
3 participants