Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix @vscode/test-electron #12709

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Fix @vscode/test-electron #12709

merged 1 commit into from
Dec 13, 2023

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented Dec 12, 2023 •
edited
Loading

The extension e2e tests are failing due to microsoft/vscode-test#246. Update @vscode/test-electron to fix it.

majastrz
majastrz approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shenglol shenglol enabled auto-merge (squash) December 12, 2023 23:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023 •
edited
Loading

Test this change out locally with the following install scripts (Action run 7188845496)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7188845496
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7188845496"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7188845496
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7188845496"

@shenglol shenglol merged commit 7880a66 into main Dec 13, 2023
45 checks passed
@shenglol shenglol deleted the shenglol/fix-vscode-test branch December 13, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shenglol @majastrz