-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS Code executable not found after downloading it #246
Comments
The second run with unrelated changes resulted in a clean run without any issues Here are two runs on on the same commit in CI:
|
Hmm, ran into this exact same issue on MacOS on the CI server https://github.com/microsoft/vscode-jupyter/actions/runs/6951074099/job/18912450458 Still trying to figure out whats going on here. |
Looks like solmething is very wrong with the way files get extracted
The files are in the wrong place. |
Found that in all of the cases downloading never goes to 100%. |
Because this is happening across different environments in your CI, and seemingly(?) only in your CI as we've not had other reports of the issue, I suspect something might be up with the archives that get downloaded. This is supported by
Currently we don't do any validation on downloaded archives, so I'll add some. |
Logan and Steven came across this in their pipeline too. |
I believe still it's a good theory with the two bullet points I mentioned. I made a fix to try to solve that, please validate it once published. Note that hash validation is only available when you ask for a specific commit in the |
Still running into this on CI, (with the latest npm package)
|
Will try a specific commit today |
I'm also hitting this. Trying with the latest npm package now... |
No luck. I'm able repro locally too. I can see that |
Rerunning CI has not fixed it for me. Maybe interesting: so far, this has only occurred in my public PR CI and locally, not in the internal CI that I have for releasing builds. Edit: actually after 5 reruns it's succeeded. |
@alexr00 can you confirm it happens when you request the version via commit hash so that it did the SHA verification after download? |
Yes, I set the |
Thanks, will try to repro and investigate more after the holiday. |
This is too coincidental with happening at the same time we're rolling out the new CDN to insider builds. Investigating... BTW, update service now has the |
Found the issue. It's indeed related to the new CDN. We're relying on the Line 223 in c1a4966
The new CDN unfortunately always sends
This explains why Windows and macOS are broken, while Linux isn't: the ZIP archives are incorrectly "detected" as TGZ. |
Fixed in 2.3.8, pipeline running |
Thank you for looking into and fixing this! I'm surprised this didn't surface in a more explicit way. I owe you a testing/debug bug fix of your choice 😁 |
Yeah me too! It turns out tar -xzf also enjoys munching on zip files and just does weird things with them. 😄 |
Fixes the frequently failing pipeline See microsoft/vscode-test#246
I get a different error now: https://dev.azure.com/vscode/vscode-pull-request-github/_build/results?buildId=109640&view=logs&j=bf770c6b-39e5-569e-4808-1859a08d14ab&t=ede73121-db1b-5427-c6bc-86115846f909 Still coming from test-electron though. |
Please ensure you're using a version of Node >=16 where the AbortController is available. |
* Update test-electron package Fixes the frequently failing pipeline See microsoft/vscode-test#246 * udpate node in pipelines
That was it, thanks! |
Fixes microsoft#246 (possibly) though it requires microsoft/vscode-update-server#167 in order to be fully functional. At minimum it validates the length of the stream matches the content-length the CDN told us about, and it will validate SHA256 checksums when the update server provides them. (I looked at getting them other ways, but it's very roundabout; the update server should just add them on all its headers.)
The extension e2e tests are failing due to microsoft/vscode-test#246. Update @vscode/test-electron to fix it.
'yarn test' downloads Visual Studio Code into a temporary directory. A change in Visual Studio Code's server caused the download to break [1]. Example error message on Windows: Test error: Error: spawn P:\quick-lint-js\plugin\vscode\.vscode-test\vscode-win32-x64-archive-1.55.2\Code.exe ENOENT Exit code: -4058 Fix the broken downloading by applying a patch to the download script [2]. [1] microsoft/vscode-test#246 [2] microsoft/vscode-test@62881f0
Does this issue occur when all extensions are disabled?: Yes/No
CI logs https://github.com/microsoft/vscode-jupyter/actions/runs/6940223424/job/18878834977
I am downloading VS Code using the package
@vscode/test-electron
I have noticed that the windows tests can fail sometimes due to some file not found error (see below).
Re-running the CI seems to fix it (hence the reason I think its flaky)
Please let me know if additional information/logs are required.
Here are the logs from the Jupyter CI
The text was updated successfully, but these errors were encountered: