Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode/test-electron to 2.3.8, fixing CI issues #414

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

zgrannan
Copy link
Contributor

Our CI seems to be failing due to microsoft/vscode-test#246; updating vscode/test-electron to the latest version should fix it.

@zgrannan
Copy link
Contributor Author

zgrannan commented Jan 20, 2024

The tests are still failing, but now for a different reason.

Some output from the macos tests:

Error: The following processes have been found: Process found: '6275 z3
6276 z3
6277 z3
6278 z3
6280 z3

@rayman2000
Copy link
Contributor

rayman2000 commented Jan 24, 2024

So the other error occurs due to processes not being cleaned up properly on Windows and Mac sometimes. I am trying to find a solution to that, but I think we can merge this right away, the problems are entirely unrelated as far as I can tell.

@rayman2000 rayman2000 merged commit f9715a7 into viperproject:master Jan 25, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants