deps: update vscode-test #4075
Merged
deps: update vscode-test #4075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem:
GHA "Insiders" jobs sometimes fail:
Error: VS Code CLI command failed (exit-code: null): /Users/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/.vscode-test/vscode-darwin-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/bin/code --extensions-dir=/Users/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/.vscode-test/extensions,--user-data-dir=/Users/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/.vscode-test/user-data,--version
at invokeVSCodeCli (/Users/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/scripts/test/launchTestUtilities.ts:68:15)
at setupVSCodeTestInstance (/Users/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/scripts/test/launchTestUtilities.ts:45:23)
at async /Users/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/scripts/test/test.ts:13:38
Failed to run tests
Error: The process '/Users/runner/hostedtoolcache/node/16.20.2/x64/bin/npm' failed with exit code 1
Solution:
Update vscode-test dependencies.
Possibly related commits:
- microsoft/vscode-test@6a41b27
- microsoft/vscode-test@91c7f9c
- microsoft/vscode-test@3558f3b
|
/runintegrationtests |
|
How did you determine that these were the changes to make here? |
It's just a guess. I watch the repo: https://github.com/microsoft/vscode-test and keep an eye on their commits. |
nkomonen-amazon
approved these changes
Nov 22, 2023
|
See microsoft/vscode-test#246 , we'll want to update again as soon as the next vscode-test package reaches NPM, to avoid CDN-related issues. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
GHA "Insiders" jobs sometimes fail:
Solution:
Update vscode-test dependencies.
Possibly related:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.