Fix some gomods issues #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should not have `v` in them, just the version itself. The `v` actively breaks jammy, but shouldn't be there anyway. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
These are distro specific and aren't really telling us anything. The main thing here is, debhelper actually changes file permissions when installing binaries which makes these tests not-portable. Beyond that, we are already testing executability, of these files so there's no need to have additional checking. We shouldn't assume that files have the exact permissions, especially with things like umask potentially affecting things as well. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Makes sure distros are tested with go modules. Also fixes the Windows implementation. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
fix_gomods_windows
branch
2 times, most recently
from
70d2066
to
fe40cca
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor fixes + fixes an issue with gomods on the windows target.
Found the gomods issue while rebasing #87.
Extracted a few of the commits out of there into this PR to address.
Some changes in this PR just made it easier to shift to a new PR.