Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some gomods issues #230

Merged
merged 3 commits into from
May 6, 2024
Merged

Fix some gomods issues #230

merged 3 commits into from
May 6, 2024

Commits on May 1, 2024

  1. test: Fix version numbers 

    These should not have `v` in them, just the version itself.
The `v` actively breaks jammy, but shouldn't be there anyway.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
    @cpuguy83
    cpuguy83 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    739779b View commit details
    Browse the repository at this point in the history

  2. Remove some useless tests 

    These are distro specific and aren't really telling us anything.
The main thing here is, debhelper actually changes file permissions when
installing binaries which makes these tests not-portable.
Beyond that, we are already testing executability, of these files so
there's no need to have additional checking.

We shouldn't assume that files have the exact permissions, especially
with things like umask potentially affecting things as well.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
    @cpuguy83
    cpuguy83 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    3a40401 View commit details
    Browse the repository at this point in the history

  3. Add distro test for go modules 

    Makes sure distros are tested with go modules.
Also fixes the Windows implementation.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
    @cpuguy83
    cpuguy83 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    fe40cca View commit details
    Browse the repository at this point in the history