Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DurableTask.AzureStorage updates to master (#187) #189

Merged
merged 7 commits into from
Jun 19, 2018
Merged

Conversation

cgillum
Copy link
Member

@cgillum cgillum commented Jun 6, 2018

Merging to master

@cgillum
Copy link
Member Author

cgillum commented Jun 6, 2018

Note-to-self: need to verify no warnings in the Release build before merging.

@cgillum cgillum changed the title DurableTask.AzureStorage API to enumerate instances (#187) DurableTask.AzureStorage updates to master (#187) Jun 15, 2018
@cgillum cgillum requested a review from simonporter June 19, 2018 19:59
@cgillum
Copy link
Member Author

cgillum commented Jun 19, 2018

Hi @simonporter, we need a new build of DurableTask.Core to be uploaded on nuget.org. The main change that affects you guys is the update of Newtonsoft.Json to v11.0.2 and WindowsAzure.Storage to v8.6.0. As part of this PR, we've also incremented the nuget package version number to 2.0.0.6. These dependency changes are specific to netstandard2.0 target and do not impact the full framework versions of the nuget packages (I assume we're the only ones who depend on the netstandard2.0 target right now).

There are several other changes to DurableTask.AzureStorage, but feel free to skip over those since we have reviewed them internally.

I have verified that there are no warnings in the Release build.

Can you please ACK if you are good with these changes?

@simonporter simonporter merged commit 53c21b9 into master Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants