Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Newtonsoft.Json to v11.0.2, WindowsAzure.Storage to v8.6.0. #193

Merged
merged 2 commits into from
Jun 15, 2018

Conversation

kashimiz
Copy link
Contributor

Updating to fix:

Azure/azure-functions-durable-extension/issues/342 (Caused by breaking change from between Newtonsoft.Json 10.0.3 and 11.0.2)
Azure/azure-functions-durable-extension/issues/343 (Caused by mismatched WindowsAzure.Storage versions between Azure Functions host and DurableTask)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we'll need to upload a new version of DurableTask.Core to nuget.org. FYI @simonporter, we'll need your assistance with this.

@kashimiz in the meantime, we can unblock testing by uploading our own private build of DurableTask.Core and DurableTask.AzureStorage to the myget feed.

@@ -13,7 +13,7 @@

<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
<PackageReference Include="ImpromptuInterface" Version="7.0.1" />
<PackageReference Include="Newtonsoft.Json" Version="10.0.3" />
<PackageReference Include="Newtonsoft.Json" Version="11.0.2" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, this means we'll also need an updated deployment of DurableTask.Core. In that case, we'll also need to increment the version of this package to 2.0.0.6 (see here).

<PackageReference Include="Newtonsoft.Json" Version="10.0.3" />
<PackageReference Include="WindowsAzure.Storage" version="8.5.0" />
<PackageReference Include="Newtonsoft.Json" Version="11.0.2" />
<PackageReference Include="WindowsAzure.Storage" version="8.6.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, no code changes are necessary?

Copy link
Contributor Author

@kashimiz kashimiz Jun 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed.

The breaking change between Newtonsoft.Json 10.0.3 and 11.0.2 is a switch from DefaultSerializationBinder inheriting from Newtonsoft.Json.Json.SerializationBinder (v10) to System.Runtime.Serialization.SerializationBinder (v11). It doesn't change the API surface of the DefaultSerializationBinder that DurableTask.Core.Serializing.PackageUpgradeSerializationBinder inherits from.
There were no breaking changes between WindowsAzure.Storage 8.5.0 and 8.6.0.

Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cgillum cgillum merged commit 21f6529 into Azure:azure-storage Jun 15, 2018
simonporter pushed a commit that referenced this pull request Jun 19, 2018
* DurableTask.AzureStorage API to enumerate instances (#187)

* DurableTask.AzureStorage ETW trace improvements (#192)

* Adding 4MB limit check for Azure Storage Table batch insert (#191)

* DurableTask.AzureStorage: Alternate fix for the 4 MB max entity size which covers more scenarios. (#194)

* Updated Newtonsoft.Json to v11.0.2, WindowsAzure.Storage to v8.6.0. (#193)

* Fixed issues with the ETW event source and added test reliability improvements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants