Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration to throw an exception when an orchestration is in an existing dedupe state #334

Merged
merged 2 commits into from
Oct 31, 2019

Conversation

amdeel
Copy link
Contributor

@amdeel amdeel commented Oct 30, 2019

Allowed configuration to throw an exception when attempting to create an orchestration instance in an existing dedupe status.

Related to this issue in azure-functions-durable-extension
Azure/azure-functions-durable-extension#367

…reate an orchestration instance in an existing dedupe state
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @ConnorMcMahon can you take a quick pass at this?

@cgillum cgillum added the durable functions This issue is an ask from the Durable Functions team. label Oct 31, 2019
Copy link
Contributor

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amdeel amdeel merged commit 05f4648 into master Oct 31, 2019
@amdeel amdeel deleted the configureExceptionWhenCreatingOrchestrator branch October 31, 2019 18:13
shankarsama pushed a commit to shankarsama/durabletask that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
durable functions This issue is an ask from the Durable Functions team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants