Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration to throw an exception when an orchestration is in an existing dedupe state #334

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Configuration to throw an exception when an orchestration is in an existing dedupe state #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
785bc3a
Made a configurable option to throw an exception when attempting to c…
amdeel Oct 30, 2019
aa728e2
changed error message
amdeel Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1242,6 +1242,11 @@ public async Task CreateTaskOrchestrationAsync(TaskMessage creationMessage, Orch
if (existingInstance != null && dedupeStatuses != null && dedupeStatuses.Contains(existingInstance.OrchestrationStatus))
{
// An instance in this state already exists.
if (settings.ThrowExceptionOnInvalidDedupeStatus)
{
throw new InvalidOperationException($"An Orchestration instance with the status {existingInstance.OrchestrationStatus} already exists.");
}

return;
}

Expand Down
5 changes: 5 additions & 0 deletions src/DurableTask.AzureStorage/AzureStorageOrchestrationServiceSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,11 @@ public class AzureStorageOrchestrationServiceSettings
/// </summary>
public BehaviorOnContinueAsNew EventBehaviourForContinueAsNew { get; set; } = BehaviorOnContinueAsNew.Carryover;

/// <summary>
/// When true, will throw an exception when attempting to create an orchestration with an existing dedupe status.
/// </summary>
public bool ThrowExceptionOnInvalidDedupeStatus { get; set; } = false;

/// <summary>
/// Returns bool indicating is the TrackingStoreStorageAccount has been set.
/// </summary>
Expand Down